Merging buffer work

Reporter: k0T0z  |  Status: open  |  Last Modified: October 01, 2023, 02:49:00 pm
This is the original PR #2309, the purpose here is to split the buffer work from compiler work.

This PR #2350 will depend on the code in this PR.

@dc03 @JoshDreamland @RobertBColton

RobertBColton  

Is this still needed for #2350?

k0T0z  
> Is this still needed for #2350?

Without this, there are some functions in the Social API that won't work such as:

  • steam_image_get_size();
  • steam_image_get_rgba();
  • steam_image_get_bgra();
  • steam_image_get_argb();
  • steam_image_create_sprite();

Note that these functions won't crash on master, it just doesn't work.

Also, @dc03 said that the buffer work can be merged into the master.

Dhruv Chawla — 05/09/2023 14:49
Josh I feel like the buffer functions (except for game_save and game_load) can be merged into master

dc03  
@k0T0z Yes, they should be merged into master, but I would prefer if it didn't involve any revert commits or merge commits... I think we should discuss this more with @JoshDreamland before moving forward with this.
k0T0z  
Oooh, forgot to mention that the work in this PR gives build failure, I had to test the Social API inside the AST-Generation branch itself.

I think this PR will be closed, and the buffer work will be merged with AST-Generation branch.

dc03  
AST-Generation is quite a ways out from being merged, I think merging the buffer work into master is a good idea.
RobertBColton  
I'll await until that discussion has happened, just ding me on this when it's ready to merge.
k0T0z  
very good then
Please sign in to post comments, or you can view this issue on GitHub.