Fix Direct3D9 Texture Creation Crash
Reporter: RobertBColton | Status: closed | Last Modified: September 06, 2020, 11:51:54 pm This fixes a mistake in #2008 where fundies accidentally put the push pixels call before the texture was actually pushed into the asset array and the id was valid. Interestingly, I noticed another mistake in here by earlier me in that I was generating mipmaps before pushing the texture pixels too, though I don't know if that one matters since the driver creates them on demand when autogen mipmaps. Added some comments while I was in here too so somebody doesn't get the order mixed up again.
codecov[bot]
Codecov Report
Merging #2137 into master will not change coverage.
The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2137 +/- ##
=======================================
Coverage 32.97% 32.97%
=======================================
Files 197 197
Lines 19051 19051
=======================================
Hits 6283 6283
Misses 12768 12768
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 819f627...bc51b38. Read the comment docs.
Leave a commentView this issue on GitHub
Please sign in to post comments, or you can view this issue on GitHub.