actually disable grpc when no grpc & fix grpc hang on linux
Reporter: fundies | Status: closed | Last Modified: March 14, 2020, 08:53:58 am partner of enigma-dev/RadialGM#101
fundies
@RobertBColton review pls
Yeah I was thinking about this, do you just want me to check if it still works ok for me?
no harm in checking but idc if it breaks for you so :P
# Codecov Report
Merging #1919 into master will decrease coverage by
0.03%
.
The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1919 +/- ##
==========================================
- Coverage 28.35% 28.31% -0.04%
==========================================
Files 167 167
Lines 16983 17028 +45
==========================================
+ Hits 4815 4821 +6
- Misses 12168 12207 +39
Impacted Files | Coverage Δ | |
---|---|---|
...GMAsystem/SHELL/Universal_System/image_formats.cpp | 22.15% <0.00%> (-2.85%) |
⬇️ |
ENIGMAsystem/SHELL/Platforms/xlib/XLIBwindow.cpp | 50.75% <0.00%> (-1.32%) |
⬇️ |
ENIGMAsystem/SHELL/Universal_System/roomsystem.cpp | 29.23% <0.00%> (-0.13%) |
⬇️ |
ENIGMAsystem/SHELL/Universal_System/estring.cpp | 86.69% <0.00%> (ø) |
|
...GMAsystem/SHELL/Platforms/General/PFthreads_impl.h | 0.00% <0.00%> (ø) |
|
...system/SHELL/Graphics_Systems/OpenGL1/GLSLshader.h | 0.00% <0.00%> (ø) |
|
...system/SHELL/Widget_Systems/None/nowidget_impl.cpp | 4.34% <0.00%> (ø) |
|
...tem/SHELL/Graphics_Systems/General/GSvertex_impl.h | 88.57% <0.00%> (ø) |
|
...tem/SHELL/Graphics_Systems/OpenGL-Common/types.cpp | 0.00% <0.00%> (ø) |
|
...m/SHELL/Graphics_Systems/General/GStextures_impl.h | 100.00% <0.00%> (ø) |
|
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8ca7150...4cc3133. Read the comment docs.
Leave a commentView this issue on GitHub
Please sign in to post comments, or you can view this issue on GitHub.