Match failure.

Begin FreeBSD Support

Reporter: time-killer-games  |  Status: open  |  Last Modified: June 28, 2020, 09:10:01 PM

Waiting for Josh to finish some stuff with JDI, in the meantime, you can make games for FreeBSD using this branch; I also finally got audio working but it requires building with clang instead of gcc. :D

jC26vln

Install instructions: https://enigma-dev.org/docs/Wiki/Install:FreeBSD

codecov[bot]  
>Codecov Report

Merging #1916 into master will decrease coverage by 0.00%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   30.94%   30.93%   -0.01%     
==========================================
  Files         197      198       +1     
  Lines       19100    19102       +2     
==========================================
  Hits         5910     5910              
- Misses      13190    13192       +2     
Impacted Files Coverage Δ
...ystem/SHELL/Platforms/xlib/Linux/LINUXjoystick.cpp 45.08% <ø> (ø)
ENIGMAsystem/SHELL/Platforms/xlib/XLIBmain.cpp 32.00% <ø> (ø)
...stem/Extensions/DataStructures/data_structures.cpp 50.51% <0.00%> (-0.11%) ⬇️
...ELL/Platforms/General/POSIX/Linux/LINUXprogdir.cpp 100.00% <100.00%> (ø)
...NIGMAsystem/SHELL/Platforms/General/POSIX/main.cpp 92.30% <100.00%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eac75d...e5a2c6b. Read the comment docs.

time-killer-games  

@fundies also @JoshDreamland said he has a few changes to make to JDI before its ready to be added to this pr. So we can't merge this until he does that and I have the correct JDI changes.
fundies  

I said nothing about closing your pr. I said i would tell him not to merge it because there's a stl function that you refuse to read docs on. Therefore, he simply shouldn't merge it until you do it correctly. Also, you begging josh for the answer isn't really learning but if he wants to spoon feed you, that's his prerogative
EnigmaBot  

UNMATCHED: Regression tests have indicated that graphical changes have been introduced. Carefully review the following image comparison for anomalies and adjust the changeset accordingly.

3dbac8f Master Diff
Image Diff Image Diff Screen Save

fundies  

I'm reposting this here because you're abusing gh's features to mark stuff as resolved that has not yet been resolved

As previously mentioned you can just assign to underlying data of the std::string instead of allocating your own buffer in your program_dir funcs.

Also I still have gripes about setting new random seed every time you call shuffle as I feel it's only going to compound our existing random issues

RobertBColton  

That's not how open source works, this isn't a race to get things into enigma-dev, all changes need thoroughly vetted. All I said is I want it in smaller pieces, because I am exhausted from having to backtrack all the time to patch over stuff that keeps breaking. If it was, most of it would probably be merged already.
time-killer-games  

@JoshDreamland since Robert didn't explain any specific ways to break this up, I have two questions.

  1. Any chance you could list your objections to this pr so we may discuss ways to resolve them?

  2. Are you going to enforce what Robert is telling me to do? All it seems to accomplish is create a lot of extra work for me needlessly, when there is enough to be done about this monster pr as it is.

  3. There are actually 3 questions not 2, I can't count. If you do want me to break this up, could you explain to me more specifically what needs to be split up and how many pr's this should be turned into? That way I won't need to go back and make corrections on splitting it up how you guys wanted.

RobertBColton  

Ideally I'd like to see. Feel free to combine the last two though and just send 3 pulls.

  • Random stuff in one pull.
  • Directory changes in another.
  • Joysticks in a third one.
  • Everything else in a fourth.
time-killer-games  

@RobertBColton thanks now if @JoshDreamland could respond to me for the first time in months.
Please sign in to post comments, or you can view this issue on GitHub.