Instance system asan leaks

Reporter: fundies  |  Status: open  |  Last Modified: March 11, 2020, 09:48:05 AM

Instance system leaks on exit
Here:
https://github.com/enigma-dev/enigma-dev/blob/master/ENIGMAsystem/SHELL/Universal_System/Instances/instance_system.cpp#L158

And Here:
https://github.com/enigma-dev/enigma-dev/blob/master/ENIGMAsystem/SHELL/Universal_System/Instances/instance_system.cpp#L327

I can't just swap to unique_ptr because itd require 10million std::moves cause its a garbage linked list and I can't figure how to iterate and delete the list because @JoshDreamland wrote a garbage api.

JoshDreamland  
Hint: they're not unique pointers. Each instance has about four things pointing to it, on the average.

Game engines have to manage their own memory at some point. This is that point.

ASAN should be reporting that the memory is reachable. Is there a leak if you continually create and destroy instances?

fundies  

don't know / care. You allocate these pointers but you don't delete them on game exit. Delete your pointers on game exit cause your api is unclear on how to do it.
Please sign in to post comments, or you can view this issue on GitHub.