Draw Button Winding Order
Reporter: RobertBColton | Status: closed | Last Modified: July 20, 2019, 01:14:20 pm(Left is master; right is this pull request)
I've been complaining about draw_button
being screwed up on master and decided to investigate. I found that originally when I started Direct3D9 I had made some fixes to the draw_button
I added there in 9a48e64, but not to the original one. The original one had some flaws too apparently but ultimately my fix made it worse. Then what happened was we deduplicated these functions to general in 0329066 and I picked the Direct3D9 one.
Now I am sitting down, again, and making sure it's actually correct. I have fixed the winding order and added comments to easily discern which primitive is which side of the button.
Codecov Report
Merging #1819 into master will not change coverage.
The diff coverage is0%
.
@@ Coverage Diff @@
## master #1819 +/- ##
=======================================
Coverage 24.87% 24.87%
=======================================
Files 176 176
Lines 16738 16738
=======================================
Hits 4164 4164
Misses 12574 12574
Impacted Files | Coverage Δ | |
---|---|---|
...system/SHELL/Graphics_Systems/General/GSstdraw.cpp | 9.87% <0%> (ø) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 74c1864...e013498. Read the comment docs.