AssetArray ADT for Resource Storage

Reporter: RobertBColton  |  Status: closed  |  Last Modified: July 14, 2019, 05:46:04 PM

I decided to finally do that resource storage class from #1125 we've been talking about to get rid of the duplicate logic we have all over the engine. After this we just have to spread the class to all of the systems and we'll have centralized id checking for debug mode. This is better because it's less likely we'll make mistakes, as we have done in the past, when it comes to checking ids.

The main idea is that the asset array has dense storage which makes it very friendly to the cache. I use a bool to mark whether each asset is still alive. The constructor accepts the string name of the type of asset the array is storing for clearer debugging.

I have switched DirectSound to use the new asset storage so I could throw out a bunch of its broken logic.

codecov[bot]  
>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1767   +/-   ##
=========================================
  Coverage          ?   24.76%           
=========================================
  Files             ?      170           
  Lines             ?    16680           
  Branches          ?        0           
=========================================
  Hits              ?     4130           
  Misses            ?    12550           
  Partials          ?        0
Impacted Files Coverage Δ
...IGMAsystem/SHELL/Universal_System/bufferstruct.cpp 0.4% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...42e7991. Read the comment docs.

Please sign in to post comments, or you can view this issue on GitHub.