Fix using string as type/function.

Reporter: JoshDreamland  |  Status: closed  |  Last Modified: June 22, 2019, 08:26:44 AM

When we moved exclusively to namespace enigma_user, we didn't move toString there, so the function is no longer allowed in EDL. Problem is, string() was a macro to it, so that was necessarily broken.

The best option for now is to remove the macro and use just the type in EDL. EDL will not force the std::string constructor to succeed on objects passed to the method, so GCC can silently fix it in the preprocessor for the time being.

Seems the user who reported this was having other issues, but this also fixes the issue with string declarations (although tackily). We might consider still merging it.

Let's submit this for now on the grounds that it makes things better. I'll deal with the fallout later.
Please sign in to post comments, or you can view this issue on GitHub.