I fixed the file_bin_rewrite
function to be more GM8.1 compatible. Now it will allow you to read bytes if you rewrite, write some bytes, seek, read the bytes just written. Basically the function changes the mode of the file to be read and write, regardless of what mode it was originally opened in. This is not GMSv1.4 compatible however, because they changed it to not do this.
I fixed file_copy
in here for POSIX/Linux using code provided by Josh which uses standard streams to accomplish the task. It worked pretty good locally, even copying files that were 0 bytes in size. This had to be done because the old hack didn't work with filenames that have spaces in them.
I also fixed filename_drive
which was using the wrong string find function. Since we programmed it to look for forward and backslash, we wanted find_first_of
, not find
, since the former accepts multiple characters where the latter does not.
https://en.cppreference.com/w/cpp/string/basic_string/find_first_of
https://en.cppreference.com/w/cpp/string/basic_string/find
Codecov Report
Merging #1714 into master will increase coverage by
0.93%
.
The diff coverage is100%
.
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
+ Coverage 22.1% 23.03% +0.93%
==========================================
Files 166 166
Lines 16654 16664 +10
==========================================
+ Hits 3681 3839 +158
+ Misses 12973 12825 -148
Impacted Files | Coverage Δ | |
---|---|---|
...m/SHELL/Platforms/General/POSIX/POSIXfilemanip.cpp | 35.55% <100%> (+33.05%) |
⬆️ |
ENIGMAsystem/SHELL/Universal_System/estring.cpp | 86.2% <100%> (+10.58%) |
⬆️ |
ENIGMAsystem/SHELL/Universal_System/fileio.cpp | 82.53% <100%> (+80.95%) |
⬆️ |
.../SHELL/Universal_System/Extensions/GTest/include.h | 100% <0%> (ø) |
⬆️ |
ENIGMAsystem/SHELL/Universal_System/darray.h | 89.47% <0%> (+78.94%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2081d72...3413a8b. Read the comment docs.