Match failure.

Match failure.

Match failure.

Rewrite Variant With New Templates

Reporter: JoshDreamland  |  Status: closed  |  Last Modified: May 05, 2019, 07:37:25 PM

No idea if this works. My system is sort of being batshit right now. If it doesn't work, I think anyone should be basically capable of finishing this up, at this point.
fundies  
template<typename T> enigma::StringFunc<T, bool> operator!=(const T& a, const var &b) { return b != a; }
will fix issues with mingw but the errors on the ci regarding clang seem indicative of a much larger issue of how you're doing this. I think you may be relying on gcc specific behavior regarding overloads.
EnigmaBot  

UNMATCHED: Regression tests have indicated that graphical changes have been introduced. Carefully review the following image comparison for anomalies and adjust the changeset accordingly.

7ee9510 Master Diff
Image Diff Image Diff Screen Save

codecov[bot]  

Codecov Report

Merging #1676 into master will increase coverage by 0.79%.
The diff coverage is 74.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
+ Coverage   21.38%   22.18%   +0.79%     
==========================================
  Files         167      165       -2     
  Lines       16709    16659      -50     
==========================================
+ Hits         3574     3695     +121     
+ Misses      13135    12964     -171
Impacted Files Coverage Δ
ENIGMAsystem/SHELL/Universal_System/mathnc.h 98.3% <ø> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/actions.h 0% <ø> (ø) ⬆️
...Extensions/ParticleSystems/PS_particle_emitter.cpp 0% <ø> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/roomsystem.cpp 30.73% <0%> (+0.06%) ⬆️
...system/SHELL/Widget_Systems/None/nowidget_impl.cpp 3.57% <0%> (-0.07%) ⬇️
...ystem/SHELL/Collision_Systems/Precise/PRECimpl.cpp 0% <0%> (ø) ⬆️
...stem/SHELL/Collision_Systems/Precise/PRECfuncs.cpp 0% <0%> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/lives.cpp 33.33% <0%> (+2.56%) ⬆️
ENIGMAsystem/SHELL/Universal_System/lives.h 100% <100%> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/lua_table.h 77.27% <100%> (-6.82%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8940a00...abeee7b. Read the comment docs.

EnigmaBot  

UNMATCHED: Regression tests have indicated that graphical changes have been introduced. Carefully review the following image comparison for anomalies and adjust the changeset accordingly.

9f6fc13 Master Diff
Image Diff Image Diff Screen Save

EnigmaBot  

UNMATCHED: Regression tests have indicated that graphical changes have been introduced. Carefully review the following image comparison for anomalies and adjust the changeset accordingly.

706b960 Master Diff
Image Diff Image Diff Screen Save

RobertBColton  

Alright: abeee7b

We narrowed down the issue with Key to Success and Project Mario to the room variable being uninitialized. Hopefully that fixes EnigmaBot too and we can merge this!

RobertBColton  

Haha, and nobody will ever say var is slow again!

Download Benchmark Vars GMX: benchmarkvars.zip

Var Benchmark

JoshDreamland  

What a saga. Thanks for your help, Robert and fundies.
Please sign in to post comments, or you can view this issue on GitHub.