Travis Exit Trap

Reporter: RobertBColton  |  Status: closed  |  Last Modified: July 17, 2019, 06:43:41 AM

This should stop any of the log from getting cut off by early exit. The set -e causes the log to be cutoff because Travis is not properly exited. Calling exit directly also causes the log to get cut off. This is why we had to call travis_terminate for the test harness. With this exit there should be no more cutting off of the log. We want set -e though because we want the installation of any dependencies to immediately fail the build, which it obviously should do, otherwise Travis will continue installing more dependencies (which is stupid).
codecov[bot]  
>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1667   +/-   ##
=========================================
  Coverage          ?   18.77%           
=========================================
  Files             ?      171           
  Lines             ?    16983           
  Branches          ?        0           
=========================================
  Hits              ?     3189           
  Misses            ?    13794           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...010c4de. Read the comment docs.

RobertBColton  

Closing as stale because fundies removed the early exit in #1792.
Please sign in to post comments, or you can view this issue on GitHub.