prevent out of bounds lookup on map

Reporter: fundies  |  Status: open  |  Last Modified: April 29, 2019, 04:30:45 AM
codecov[bot]  
>Codecov Report

Merging #1612 into master will increase coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1612     +/-   ##
=========================================
+ Coverage   17.62%   18.53%   +0.9%     
=========================================
  Files         166      166             
  Lines       17144    17160     +16     
=========================================
+ Hits         3022     3180    +158     
+ Misses      14122    13980    -142
Impacted Files Coverage Δ
ENIGMAsystem/SHELL/Universal_System/object.cpp 30.64% <100%> (+1.13%) ⬆️
...MAsystem/SHELL/Platforms/General/POSIX/Utility.cpp 70.37% <0%> (-6.66%) ⬇️
ENIGMAsystem/SHELL/Platforms/General/PFmain.cpp 81.81% <0%> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/var4.cpp 21.01% <0%> (+0.63%) ⬆️
ENIGMAsystem/SHELL/libEGMstd.cpp 42% <0%> (+8%) ⬆️
ENIGMAsystem/SHELL/Universal_System/estring.cpp 75.62% <0%> (+75.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0a7bf...c9c409b. Read the comment docs.

JoshDreamland  

Well, it's not useless—this changes the behavior so that if two instances have ID -1, an error is no longer generated. My question is, why is the given ID ever negative?
RobertBColton  

That's what I was asking basically! According to him I'm the one who made this change for MSVC but I can't remember and thus have little confidence in it.
Please sign in to post comments, or you can view this issue on GitHub.