prevent out of bounds lookup on map

Reporter: fundies  |  Status: open  |  Last Modified: July 17, 2019, 06:46:18 AM
>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1612   +/-   ##
  Coverage          ?   18.53%           
  Files             ?      166           
  Lines             ?    17160           
  Branches          ?        0           
  Hits              ?     3180           
  Misses            ?    13980           
  Partials          ?        0
Impacted Files Coverage Δ
ENIGMAsystem/SHELL/Universal_System/object.cpp 30.64% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...c9c409b. Read the comment docs.


Well, it's not useless—this changes the behavior so that if two instances have ID -1, an error is no longer generated. My question is, why is the given ID ever negative?

That's what I was asking basically! According to him I'm the one who made this change for MSVC but I can't remember and thus have little confidence in it.

@fundies you could try fixing this the right way now that you have DEBUG_MESSAGE merged.
Please sign in to post comments, or you can view this issue on GitHub.