fixed a couple things with get_directory()

Reporter: time-killer-games  |  Status: open  |  Last Modified: March 19, 2019, 10:41:23 AM

  • Robert was an idiot and either didn't know how to set the default directory or was too lazy to do it, so I took care of that for him.
  • He wrote it originally with a bug regarding the flags which allowed selecting non-directory locations that returned CLSID's instead of paths, which I also fixed by preventing those from being selectable, forcing only valid paths to be selectable.
  • <
codecov[bot]  
>Codecov Report

Merging #1600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1600   +/-   ##
=======================================
  Coverage   17.62%   17.62%           
=======================================
  Files         166      166           
  Lines       17144    17144           
=======================================
  Hits         3022     3022           
  Misses      14122    14122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5d3c3...3c54d2e. Read the comment docs.

time-killer-games  

@RobertBColton hey if Josh doesn't review this soon any chance if you could?
time-killer-games  

@JoshDreamland all checks have passed. This one is ready for you to review.
time-killer-games  

@RobertBColton @JoshDreamland are one of you stinkers gonna review this?
time-killer-games  

@RobertBColton I'm getting the vibe you are either ignoring me or don't find this pr that important enough to be a priority to merge. I'm hoping it's the latter and not the former.
fundies  

only im allowed to call @RobertBColton an idiot
time-killer-games  

#bromance
time-killer-games  

@JoshDreamland hey pooky u merge?
Please sign in to post comments, or you can view this issue on GitHub.