Isolate EnigmaStruct family of structures.

Reporter: JoshDreamland  |  Status: closed  |  Last Modified: March 15, 2019, 07:34:08 PM

Move them to namespace deprecated::JavaStruct where they won't interfere with protos and other libraries.

Fixes #1594.
Fixes #1593.

>Codecov Report

Merging #1595 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1595      +/-   ##
- Coverage   17.62%   17.62%   -0.01%     
  Files         166      166              
  Lines       17143    17144       +1     
  Hits         3022     3022              
- Misses      14121    14122       +1
Impacted Files Coverage Δ
...L/Universal_System/Extensions/Paths/pathstruct.cpp 42.37% <0%> (-0.37%) ⬇️
...tensions/MotionPlanning/motion_planning_struct.cpp 0% <0%> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/zlib.cpp 16.66% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36deed...d37731c. Read the comment docs.


What @fundies said has some truth to it. emake is the only place in our stuff using EnigmaStruct, for an empty game. Changing it would speed up running empty games from emake since it wouldn't have to go through the conversion to GameData. Our continuous integration happens to run empty games a lot, so it would maybe shave a few minutes off the total run time of our CI builds.

I'll assume he meant Proto, not GameData. And for the most part, it is. As you can see, it's only currently using EnigmaStruct as a storage mechanism for SOG, which I am removing locally. For now, this can submit as-is.
Please sign in to post comments, or you can view this issue on GitHub.