Execute Shell Return Code

Reporter: RobertBColton  |  Status: open  |  Last Modified: March 12, 2019, 11:32:49 PM

This is for hugar. WIP
codecov[bot]  
>Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   17.62%   17.62%           
=======================================
  Files         166      166           
  Lines       17143    17143           
=======================================
  Hits         3022     3022           
  Misses      14121    14121
Impacted Files Coverage Δ
...MAsystem/SHELL/Platforms/General/POSIX/Utility.cpp 77.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4fc18...cd50eb0. Read the comment docs.

RobertBColton  

@time-killer-games I don't know, I wasn't paying attention but I just wanted to show this. I think you are doing something more special than I am, these functions should obviously return the exit code. I am not talking about the return values of the command (like the program returning a string), just its exit code. I think every main() entry point of an executable has only a single return? And that's even specified by each operating system?
time-killer-games  

What does he need the exit code for? I seriously doubt he needs it or even knows what it's for.
RobertBColton  

I think you're right and that what he was trying to do, get the result of a KDialog call, won't work this way. However, that does not change the fact that people might want to get the exit code of these functions. I think it's silly that GM doesn't return it in GM8. Also, we can make this change backwards compatibly. It's unlikely, if not impossible, that this breaks anything.
time-killer-games  

I can close my other pr and let you make your own version of it if you want. I spent since before the crack of dawn yesterday to after 11pm working on It, just for Josh to tell me he doesn't like any of my code and tells me to redo it with a completely different approach, and just because Windows doesn't support a function I was using. Even though technically, Windows should be completely different code regardless so that we can have utf-8 support, but Josh was being so arrogant and fucktarded I decided to keep that important detail to myself that he somehow forgot.
RobertBColton  

No, please don't, I didn't want to do anything but show this simple GM API can be improved. I don't know much about the other thing, but I am not really too interested in this topic, I am just trying to help. Maybe what he's wanting you to do is just to break it down into more abstractions?
Please sign in to post comments, or you can view this issue on GitHub.