Fix Windows Fullscreen Toggle

Reporter: RobertBColton  |  Status: closed  |  Last Modified: July 27, 2019, 11:53:12 AM

>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1576   +/-   ##
  Coverage          ?   17.62%           
  Files             ?      166           
  Lines             ?    17143           
  Branches          ?        0           
  Hits              ?     3022           
  Misses            ?    14121           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...4cfc998. Read the comment docs.


Just tested this, doesn't seem to do anything for #1549

Alright, so I think what the issue may be then is that xlib just does fullscreen different from Windows. I don't know if xlib requires that, in addition to adding or removing the atom, we resize the window to cover the screen like faux fullscreen on Windows does. This is going to be difficult to reconcile the differences between xlib and Windows here for this reason.

You could try commenting out the enigma::compute_window_size in xlib's window_set_fullscreen and just see what adding and removing the atom alone does.



Yeah I've already tried playing around with the atom & compute_window_size(), only made the problem worse.

Ok, thanks. I think we should start with still pushing this through for Windows, because I am sick of it not working here too. Then I'll try to get Josh to actually poke around xlib or else try to boot a VM myself. One more thing I have to say is that, for me, this work around still seems to have the scaling issues you speak of in SDL but not in Win32. You could still also try this fix with SDL for me, because if I can also get SDL working perfectly you can temporarily build your game with that platform, if you like of course.

PS: This still needs tweaked, I don't want to submit this as-is the way I have it.


My pr fixes this: #1831 @RobertBColton please close this along with any other pr's that would potentially break my fixes.
Please sign in to post comments, or you can view this issue on GitHub.