Linux Pollution Cleanup & Time Test

Reporter: RobertBColton  |  Status: closed  |  Last Modified: April 23, 2019, 08:54:19 PM

This pull request is a friend of #1445 that attempts to CI test #1327 to prevent it from coming back. I basically just moved the includes around so that <X11/Xlib.h> is not included in SHELLmain and only the headers with user functions are. This is why XLIBmain.h and XLIBwindow.h are not included in Platforms/xlib/include.h anymore, because they only have implementation stuff, no actual user functions declared in them. Most platform user functions have their declarations generalized now anyway.

My change to the math test produced this in the test harness job of the first commit of this pull request:

Line 213, position 6 (absolute 8474): Invalid assignment to function `time'

That means the test successfully reproduced the bug in #1327. Now I've merged in the latest master with #1677 which actually fixes #1327 so the test should pass.

>Codecov Report

Merging #1446 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1446   +/-   ##
  Coverage   18.82%   18.82%           
  Files         169      169           
  Lines       16782    16782           
  Hits         3159     3159           
  Misses      13623    13623
Impacted Files Coverage Δ
...MAsystem/SHELL/Universal_System/sprites_internal.h 100% <ø> (ø) ⬆️
ENIGMAsystem/SHELL/Platforms/xlib/XLIBwindow.cpp 48.96% <ø> (ø) ⬆️
...Extensions/MotionPlanning/motion_planning_struct.h 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba658bd...9a5fa0f. Read the comment docs.


Ok: 9a5fa0f

Your call boss.


Thanks. Silly to patch something that simple in code that's going away.

That's true, now I see what you mean, the var pull request.
Please sign in to post comments, or you can view this issue on GitHub.