Automatically Append Build Extension
Reporter: RobertBColton | Status: open | Last Modified: July 19, 2019, 09:18:45 AMSimple fix here to automatically append the
.exe extension or whatever the current target uses if the passed exe filename does not already end with it. This is useful so I don't have to piss with it in RGM by adding special checks for Windows or extend the proto information with more YAML. It also makes it easier to add a new IDE, I mean, if ENIGMA is going to have that information in its YAML files, why not use it.
Tested and confirmed working with RGM and emake and an empty game.
RobertBColton @JoshDreamland this one is ready to go when you get a chance, thanks!
Codecov Report
❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #1415 +/- ##
=========================================
Coverage ? 17.62%
=========================================
Files ? 166
Lines ? 17143
Branches ? 0
=========================================
Hits ? 3021
Misses ? 14122
Partials ? 0Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 3031c06...1f39aba. Read the comment docs.
@fundies I think I changed my mind on this one. I'm not sure, I don't know. It still feels like something IDE should enforce. If user really wants to create exe without the exe extension they should be able to, which LGM's file save for compile dialog does (All Files/Executable Files). It's really only Windows that's the anomaly here.
@RobertBColton well make up your mind and close or merge instead of letting it sit here for another year :P
Leave a commentView this issue on GitHub
Please sign in to post comments, or you can view this issue on GitHub.