Common Vertex Formats

Reporter: RobertBColton  |  Status: open  |  Last Modified: July 14, 2019, 05:26:53 PM

This pull request was originally optimization related since defining vertex formats was performing poorly until #1372 was merged. Now the pull request is just being left open as a proposed API. The idea behind this is to make it easy to define a simple vertex format and is inspired by Direct3D's now-deprecated Flexible Vertex Formats.

The pull request adds the vertex_format_define function which accepts a combination of cvf_* constants and returns an id to a vertex format created from the flags. The function is generic and also has a redundant cache to make it even faster to create a common vertex format (e.g, just position and color or other formats I consider "simple" or "common").

codecov[bot]  
>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1369   +/-   ##
=========================================
  Coverage          ?   22.07%           
=========================================
  Files             ?      166           
  Lines             ?    16676           
  Branches          ?        0           
=========================================
  Hits              ?     3681           
  Misses            ?    12995           
  Partials          ?        0
Impacted Files Coverage Δ
...system/SHELL/Graphics_Systems/General/GSvertex.cpp 50% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...f95983b. Read the comment docs.

Please sign in to post comments, or you can view this issue on GitHub.