Common Vertex Formats
Reporter: RobertBColton | Status: closed | Last Modified: December 30, 2020, 11:19:23 pm This pull request was originally optimization related since defining vertex formats was performing poorly until #1372 was merged. Now the pull request is just being left open as a proposed API. The idea behind this is to make it easy to define a simple vertex format and is inspired by Direct3D's now-deprecated Flexible Vertex Formats.
The pull request adds the vertex_format_define
function which accepts a combination of cvf_*
constants and returns an id to a vertex format created from the flags. The function is generic and also has a redundant cache to make it even faster to create a common vertex format (e.g, just position and color or other formats I consider "simple" or "common").
codecov[bot]
Codecov Report
Merging #1369 into master will decrease coverage by
0.02%
.
The diff coverage is0%
.
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
- Coverage 22.1% 22.07% -0.03%
==========================================
Files 166 166
Lines 16654 16676 +22
==========================================
Hits 3681 3681
- Misses 12973 12995 +22
Impacted Files | Coverage Δ | |
---|---|---|
...system/SHELL/Graphics_Systems/General/GSvertex.cpp | 50% <0%> (-4.79%) |
⬇️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a176df1...f95983b. Read the comment docs.
Leave a commentView this issue on GitHub
Please sign in to post comments, or you can view this issue on GitHub.