XLIB Resizeable Fix

Reporter: RobertBColton  |  Status: closed  |  Last Modified: July 24, 2019, 11:53:35 AM

Ok, so this function never worked on xlib, and I first tried to add it in 4c735ab, but obviously never tested it. The issue was recently reported in #1334 and I'd like to get it fixed since it does work on SDL/Win32, but the user is on Linux and also has an issue with SDL because of #1340.

Apparently the way to disable resizing in XLIB is to set the min/max size hints of the window equal to each other, in this case I set them both to the dimensions of the window. It's not clear to me, and I could find no information pertaining to it on the web, whether setting the min/max to 0 will allow the window to be resizeable again or not. If not, then enabling the sizeable property of the window should be fixed if somebody can figure it out.

>Codecov Report

❗️ No coverage uploaded for pull request base (master@3031c06). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1341   +/-   ##
  Coverage          ?   16.74%           
  Files             ?      164           
  Lines             ?    17093           
  Branches          ?        0           
  Hits              ?     2862           
  Misses            ?    14231           
  Partials          ?        0
Impacted Files Coverage Δ
ENIGMAsystem/SHELL/Platforms/xlib/XLIBwindow.cpp 48.67% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031c06...c1c0ed3. Read the comment docs.


Closing in favor of #1831 since TKG is attempting to work this one out and he's on Linux where he can actually test that it does what it should do.
Please sign in to post comments, or you can view this issue on GitHub.