XLIB Resizeable Fix

Reporter: RobertBColton  |  Status: open  |  Last Modified: November 12, 2018, 08:29:07 PM

Ok, so this function never worked on xlib, and I first tried to add it in 4c735ab, but obviously never tested it. The issue was recently reported in #1334 and I'd like to get it fixed since it does work on SDL/Win32, but the user is on Linux and also has an issue with SDL because of #1340.

Apparently the way to disable resizing in XLIB is to set the min/max size hints of the window equal to each other, in this case I set them both to the dimensions of the window. It's not clear to me, and I could find no information pertaining to it on the web, whether setting the min/max to 0 will allow the window to be resizeable again or not. If not, then enabling the sizeable property of the window should be fixed if somebody can figure it out.

codecov[bot]  
>Codecov Report

Merging #1341 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   16.74%   16.74%   +<.01%     
==========================================
  Files         164      164              
  Lines       17095    17093       -2     
==========================================
  Hits         2862     2862              
+ Misses      14233    14231       -2
Impacted Files Coverage Δ
ENIGMAsystem/SHELL/Platforms/xlib/XLIBwindow.cpp 48.67% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950036a...c1c0ed3. Read the comment docs.

Please sign in to post comments, or you can view this issue on GitHub.