Added url_open() and associated functions

Reporter: faissaloo  |  Status: closed  |  Last Modified: October 20, 2017, 10:07:16 AM

Fixes #1039
I decided to have it so url_open() can optionally take the arguments specified for its associated functions, url_open_ext() and url_open_full(), since they extend each other in case some platform can actually implement them.
Also implemented action_webpage() for Linux while I was at it.
This looks great to me, and all checks are passing. I thought those url_* functions were in the Networking System but apparently they aren't. That's ok though, we actually do want these available in the platform. I have no complaints with this but I'll let @JoshDreamland review it just in case. Taking the raw string and sending it like that to system() without any sanitizing may be a security vulnerability, but no more than system() itself would be a security vulnerability. Maybe we should just document it on the wiki somewhere.

Edit: I'm waiting for Josh to reply and tell me what his preferred merge style is. Last night I merged mine with a rebase so it looks like I had no pr. It seems he prefers the squash route, so just double checking.


Just a note too, I can add it to Windows if you aren't able to right now after yours is merged.

@RobertBColton Yes I would appreciate that, thanks

Bump @RobertBColton @JoshDreamland

Notice: Undefined variable: context in /var/www/html/ on line 114
Please sign in to post comments, or you can view this issue on GitHub.