Pages: 1 2 »
  Print  
Author Topic: Inheritance Fixes  (Read 2562 times)
Offline (Male) Goombert
Posted on: April 26, 2014, 04:55:02 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
So I have finally got around to fixing the remaining inheritance issues, mainly event_inherited now works inside all events including alarms, collisions, et all, I also fixed the No More Health event from firing more than once, it behaves as GM8.1 and Studio now. I also fixed the debug warnings in an empty game. I did these changes with the help of Josh, and he approves them as well. I have tested several individual cases to ensure that the fixes work, that none of the old behavior has broken, and that no new issues have arisen. I also tested on several EDC games and some of your individual games that you all have sent me over a period of some time.

To test these changes you can pull from master, or simply download the new Portable ZIP. If you encounter any issues as a result of these changes please notify me immediately and I will fix them right away.
http://enigma-dev.org/docs/Wiki/Install:Windows

I will also take time to respond to the rest of your bug reports later today.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) The 11th plague of Egypt
Reply #1 Posted on: April 26, 2014, 07:12:47 AM
Member
Joined: Dec 2009
Posts: 276

View Profile
Welcome fixes!
Logged
Offline (Unknown gender) egofree
Reply #2 Posted on: April 27, 2014, 04:15:24 AM
Contributor
Joined: Jun 2013
Posts: 603

View Profile Email
That's great. Inheritance is very important. Robert, you are my hero !  :D
Logged
Offline (Male) Goombert
Reply #3 Posted on: April 27, 2014, 08:30:33 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
Just make sure it all works properly before thanking me you guys.  ;D
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) egofree
Reply #4 Posted on: April 28, 2014, 04:29:06 AM
Contributor
Joined: Jun 2013
Posts: 603

View Profile Email
Ok, i tried again my old project ('Son of blagger') with the latest version of ENIGMA. I spent two hours to figure out why inheritance was not working at all with my project ! : in the enigma settings, the 'Object inheritance' option is not selected by default. I think it should be always selected when you load an old project. This is the case if you create a new project.
Logged
Offline (Male) Goombert
Reply #5 Posted on: April 28, 2014, 04:37:13 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
Ok, so couple of questions. The inheritance did work correctly in your game though right? And was your game saved as an EGM? It probably never had the setting because it was a new setting, if you set it true and save again it should be set to true every time you load after that.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) egofree
Reply #6 Posted on: April 28, 2014, 04:44:01 AM
Contributor
Joined: Jun 2013
Posts: 603

View Profile Email
Ok, so couple of questions. The inheritance did work correctly in your game though right? And was your game saved as an EGM? It probably never had the setting because it was a new setting, if you set it true and save again it should be set to true every time you load after that.

For the moment i can't say if the inheritance is really working, as a lot of things are still not working.  :)
Yes, i guess it's a new setting, and it's ok if i save the project and load it again. But my point is this : for old projects which doesn't have this setting, would it be possible to set the option as selected by default ? I spent several hours to figure out why the inheritance was not working and to find this option. By the way, why we need this option ? Shouldn't inheritance always works ?
Logged
Offline (Male) Goombert
Reply #7 Posted on: April 28, 2014, 04:50:25 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
I can't really do that ego, I'd have to make a special exception for that one setting, right now the EGM reader just sees if you have the setting entered and if not sets it to 0/null/or false.

Anyway, the setting is so that people who use parenting only for collision detection, people like cheeseboy, but don't actually want the objects inheriting anything. The only reason I agreed to add it for him was so that if users had issues resulting from my inheritance additions they could turn it off and make sure its not my event inheritance code causing the issue.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) egofree
Reply #8 Posted on: April 28, 2014, 06:08:49 AM
Contributor
Joined: Jun 2013
Posts: 603

View Profile Email
As objects inheritance should work without any problems right now, i think we should remove this option, and have objects inheritance always activated. Otherwise new comers (usually they are already GM users), will try to load their projects and think objects inheritance is not working.
« Last Edit: April 28, 2014, 07:39:50 AM by egofree » Logged
Offline (Male) Goombert
Reply #9 Posted on: April 28, 2014, 03:03:15 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
Oh no, it is on by default for GMK and GMX projects, and EGM's too, just not old EGMs.  (Y)
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) TheExDeus
Reply #10 Posted on: April 29, 2014, 07:07:16 AM

Developer
Joined: Apr 2008
Posts: 1872

View Profile
Quote
As objects inheritance should work without any problems right now, i think we should remove this option, and have objects inheritance always activated. Otherwise new comers (usually they are already GM users), will try to load their projects and think objects inheritance is not working.
There are many, like me for example, that don't use inheritance EVER. So removing the possibility to disable useless functionality isn't a good idea. Especially if the option works. So default behavior could be changed, but I doubt this should be removed.
I have used GM since about 2002 and I have actually used inheritance once, when I was following a tutorial.
Logged
Offline (Unknown gender) daz
Reply #11 Posted on: April 29, 2014, 01:19:15 PM
Contributor
Joined: Jul 2010
Posts: 167

View Profile
I like to use inheritance quite a lot so it's great for me. I don't think inheritance would have a very big overhead, so I don't really see a need for it to be modularized, but on the other hand more modularity is always good for efficiency I suppose, no matter how slight that might be -- it'll add up.
Logged
Offline (Unknown gender) Darkstar2
Reply #12 Posted on: April 29, 2014, 04:13:27 PM
Member
Joined: Jan 2014
Posts: 1244

View Profile Email
I agree with Harri :)  I rarely if at all use inheritance and I agree it should be optional.
Logged
Offline (Male) Goombert
Reply #13 Posted on: April 29, 2014, 05:18:04 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3108

View Profile
Inheritance is very important if you try to make a very big game, it's not quite as important in GM because of the pretty much unified type system (all objects inherit the same default locals).
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) egofree
Reply #14 Posted on: May 05, 2014, 07:26:32 AM
Contributor
Joined: Jun 2013
Posts: 603

View Profile Email
Robert, I did more tests concerning inheritance, and so far all features seem to work correctly.  (Y)
Logged
Pages: 1 2 »
  Print