Pages: 1
  Print  
Author Topic: All EGM's Broke  (Read 1466 times)
Offline (Male) Goombert
Posted on: December 14, 2013, 06:32:40 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 2993

View Profile
Well I had to add the "Force software vertex processing" setting to Global Game Settings and found a real nasty bug.

If an EGM is saved with older global game settings it fails to load with the latest version. If you update LGM or the plugin any time lately you'll need to patch up your EGM's too, it is real simple, the bug is already filed on the tracker as well.

Since EGM is simply a ZIP file just open it up and add "FORCE_SOFTWARE_VERTEX_PROCESSING: false" to Game Settings.ey file then rezip or whatever. I already updated all my EGM's on the site.

You can also just download the new Portable ZIP.
http://enigma-dev.org/docs/Wiki/Install:Windows

This is the open bug report.
https://github.com/enigma-dev/lgmplugin/issues/12
« Last Edit: December 14, 2013, 06:35:20 AM by Robert B Colton » Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) TheExDeus
Reply #1 Posted on: December 14, 2013, 02:12:12 PM

Developer
Joined: Apr 2008
Posts: 1860

View Profile
So that stuff like this doesn't break anything in the future we should probably just assign default values when loading. So in the LGM you just see if the EGM has the certain parameter and if not, then set it to some value (in this case I guess it's False).
Logged
Offline (Male) Goombert
Reply #2 Posted on: December 14, 2013, 08:48:38 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 2993

View Profile
Yup; yup; that's why I made a ticket, I'm just feelin lazy :P
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Male) cheeseboy
Reply #3 Posted on: December 14, 2013, 11:44:26 PM

Member
Location: The internet
Joined: Mar 2011
Posts: 105

View Profile
So that stuff like this doesn't break anything in the future we should probably just assign default values when loading. So in the LGM you just see if the EGM has the certain parameter and if not, then set it to some value (in this case I guess it's False).

Or we could ban robert
Logged
Offline (Male) Josh @ Dreamland
Reply #4 Posted on: December 15, 2013, 08:16:34 AM

Prince of all Goldfish
Developer
Location: Pittsburgh, PA, USA
Joined: Feb 2008
Posts: 2949

View Profile Email
There is no reason an EGM should EVER have this problem. The reason it is a zip file with plain-text attributes is so no harm can come of a missing attribute. Or missing resource. Or missing anything. And new information can always be added without any such fears.
Logged
"That is the single most cryptic piece of code I have ever seen." -Master PobbleWobble
"I disapprove of what you say, but I will defend to the death your right to say it." -Evelyn Beatrice Hall, Friends of Voltaire
Offline (Unknown gender) FroggestSpirit
Reply #5 Posted on: December 15, 2013, 07:57:32 PM

Member
Joined: Mar 2013
Posts: 79

View Profile
I just updated a minute ago, do I need to worry about this?
Logged
This isn't easy to say, but…
Offline (Male) Goombert
Reply #6 Posted on: December 15, 2013, 09:22:45 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 2993

View Profile
This is the exception that occurs, I did nothing more than add the property to the game settings property structures.

Quote
Exception in thread "main" java.lang.NullPointerException
   at org.enigma.file.EFileReader$DataPropReader.convert(EFileReader.java:423)
   at org.enigma.file.EFileReader$DataPropReader.put(EFileReader.java:444)
   at org.enigma.file.EFileReader$DataPropReader.readProperties(EFileReader.java:387)
   at org.enigma.file.EFileReader$DataPropReader.read(EFileReader.java:375)
   at org.enigma.file.EFileReader$DataPropReader.readUnknown(EFileReader.java:364)
   at org.enigma.file.EFileReader.readResource(EFileReader.java:634)
   at org.enigma.file.EFileReader.processEntries(EFileReader.java:611)
   at org.enigma.file.EFileReader.readNodeChildren(EFileReader.java:589)
   at org.enigma.file.EFileReader.readEgmFile(EFileReader.java:533)
   at org.enigma.file.EFileReader.readEgmFile(EFileReader.java:516)
   at org.enigma.file.EgmIO.read(EgmIO.java:56)
   at org.lateralgm.main.FileChooser.open(FileChooser.java:533)
   at org.lateralgm.main.FileChooser.open(FileChooser.java:519)
   at org.lateralgm.main.LGM.main(LGM.java:809)

Edit: I have fixed this in a new pull request by simply checking if a null value is being added to the property list, and if so not adding it and keeping the default.

https://github.com/enigma-dev/lgmplugin/commit/a5bc74ae5939e366dfaf048de69a351875d05c77

Please redownload the plugin, the latest version will not have broke EGM's.
« Last Edit: December 15, 2013, 09:47:13 PM by Robert B Colton » Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Pages: 1
  Print