Pages: 1
  Print  
Author Topic: Everything Is Good Now  (Read 3024 times)
Offline (Male) Goombert
Posted on: August 28, 2013, 04:10:24 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
I believe the issues with the executable have been resolved, it is now working for me again, Harri, polygonz, and frogg. So let's just not mess with the exe quite some time, the only thing it needs is automatic updates to download binaries, I will finish it myself at a later point in time.

Polygonz, please try not to do shit like remove glewInit() from OpenGL 1, like seriously, do you even think before you commit anything?

This is the kind of responses we end up getting on our Facebook as a result...
Quote
Yeah... Its crashed on first run for me... I will send bug report next weekend
Quote
Janko Knez I suggest you focus on the bugs first, then add features.

We need to at least try not to break EVERYTHING all at one time ;_;
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) TheExDeus
Reply #1 Posted on: August 28, 2013, 07:33:17 AM

Developer
Joined: Apr 2008
Posts: 1872

View Profile
I think integration testing was almost complete. A little bit of automation, server space (which Josh has now as far as I know) and it should be good.
Someone (probably Fervi) just has to make a simple tutorial with guidelines on how exactly we use it.
Logged
Offline (Male) Goombert
Reply #2 Posted on: August 28, 2013, 07:41:35 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
Harri, what did you mean by you can't get shaders working? I thought they were working for you in the past?
« Last Edit: August 28, 2013, 08:58:48 AM by Robert B Colton » Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Male) polygone
Reply #3 Posted on: August 28, 2013, 08:55:34 AM

Contributor
Location: England
Joined: Mar 2009
Posts: 803

View Profile
Polygonz, please try not to do shit like remove glewInit() from OpenGL 1, like seriously, do you even think before you commit anything?
I never did that. Please try to stop saying things I've done when I haven't done them.
Logged
I honestly don't know wtf I'm talking about but hopefully I can muddle my way through.
Offline (Male) Goombert
Reply #4 Posted on: August 28, 2013, 08:59:55 AM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
@polyfaggot
https://github.com/enigma-dev/enigma-dev/commit/06be021c447b430bf9e1723f45d10a40847596e4

CTRL+F for "glewInit()" you did fucking too broke it, but its fine Josh already merged and fixed it.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Male) polygone
Reply #5 Posted on: August 28, 2013, 09:06:42 AM

Contributor
Location: England
Joined: Mar 2009
Posts: 803

View Profile
@polyfaggot
https://github.com/enigma-dev/enigma-dev/commit/06be021c447b430bf9e1723f45d10a40847596e4

CTRL+F for "glewInit()" you did fucking too broke it, but its fine Josh already merged and fixed it.
-    GLenum err = glewInit();
-         #ifdef DEBUG_MODE
+    GLenum err = glewInit();

Oh yeah I relocated it because the err variable wasn't used and threw a warning, but I didn't put add the call back in for when not in debug mode.

I'm shocked though that Josh just fixed it instead of complaining about it and leaving it broken... ? Maybe he's learnt.
« Last Edit: August 28, 2013, 09:23:41 AM by polygone » Logged
I honestly don't know wtf I'm talking about but hopefully I can muddle my way through.
Offline (Unknown gender) TheExDeus
Reply #6 Posted on: August 28, 2013, 10:21:00 AM

Developer
Joined: Apr 2008
Posts: 1872

View Profile
Quote
I'm shocked though that Josh just fixed it instead of complaining about it and leaving it broken... ? Maybe he's learnt.
Robert fixed it, not Josh.

Quote
Harri, what did you mean by you can't get shaders working? I thought they were working for you in the past?
They never worked for me. I thought I was pretty clear on that. I will check and see if glsl_shader_get_infolog(id) returns something.

In other news, I just upgraded to the newest ENIGMA.exe and you DID break it. That directory check should be this:
Code: [Select]
if (ftyp == INVALID_FILE_ATTRIBUTES || !(ftyp & FILE_ATTRIBUTE_DIRECTORY))notice the or || instead of and &&. Technically it should work with just ftyp == INVALID_FILE_ATTRIBUTES, but I guess we must make this check in cases when there is a file named enigma-dev.

edit: Is it possible to get index for each shader seperatly? Like now shr_cartoon is just one resource.. so how can I link it manually? And how can I get error for each script manually? You didn't add error reporting in OPENGL3std and I did that myself. But to get errors I had to just use glsl_shader_get_infolog(0) and glsl_shader_get_infolog(1) as I cannot set it like glsl_shader_get_infolog(shr_cartoon->vertex) and glsl_shader_get_infolog(shr_cartoon->fragment). So we really need to figure this out.. if we have only one resource then some additional name param for each is needed or something.

Quote
//Vertex shader output
0(3) : warning C7555: 'varying' is deprecated, use 'in/out' instead
0(7) : error C7533: global variable gl_NormalMatrix is deprecated after version 120
0(7) : error C7533: global variable gl_Normal is deprecated after version 120
0(8) : error C7533: global function ftransform is deprecated after version 120

Quote
//Fragment shader output
0(3) : warning C7555: 'varying' is deprecated, use 'in/out' instead
0(10) : error C7533: global variable gl_LightSource is deprecated after version 120
0(20) : warning C7533: global variable gl_FragColor is deprecated after version 120
So basically they are not working because they use deprecated (and in my case not supported at all) stuff. We need to add matrices and stuff ourselves.

edit2: I just remembered you set the version at the top of the shader. So I just changed 330 to 120 and voila.. it works. But we do need to make them 330 compatible with passing our own matrices anyway.
« Last Edit: August 28, 2013, 11:08:34 AM by TheExDeus » Logged
Offline (Male) polygone
Reply #7 Posted on: August 28, 2013, 11:11:31 AM

Contributor
Location: England
Joined: Mar 2009
Posts: 803

View Profile
After Josh eventually finishes JDI we can make a stable release, I don't see the point until that happens. Also we're still waiting on forthevin's idea of having automated regression testing.
Logged
I honestly don't know wtf I'm talking about but hopefully I can muddle my way through.
Offline (Male) Goombert
Reply #8 Posted on: August 28, 2013, 12:59:19 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
@Harri just look at the new cubes demo, but please don't touch anything shader related for a few days I am working on the specs and getting everything perfect and also rewriting the OpenGL 3 mesh class to use a single vertex buffer and batch EVERYTHING to triangle list so models will be super fast no matter what primitive type you use. People who want to do multitexturing are advised to use the new vertex functions when I add them as Studio works the same way.



When I get all this sorted out I will upload my new version with the extra shaders like bumpmapping/etc

Also, I used the directory attributes and Josh said that was the proper way to do it.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) TheExDeus
Reply #9 Posted on: August 28, 2013, 02:10:54 PM

Developer
Joined: Apr 2008
Posts: 1872

View Profile
But the attribute is not returned if ftyp is invalid. That means the && never succeeds and thus the if is useless. At least I think it goes like that, because it doesn't work. Your probably didn't test it anyway as always.
Logged
Offline (Male) Goombert
Reply #10 Posted on: August 28, 2013, 08:03:32 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
;_; I didn't test it? I always test it, and everything I commit, especially that zip I sit and reextract when I finish applying patches and make sure each time it goes all the way through a compile for me.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) TheExDeus
Reply #11 Posted on: August 29, 2013, 01:00:38 AM

Developer
Joined: Apr 2008
Posts: 1872

View Profile
But did you try compiling from source? Like not using the zip.
Anyway, if you won't commit the change then I will later. No biggy.
Logged
Offline (Male) Goombert
Reply #12 Posted on: August 31, 2013, 02:35:11 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
I am getting to it, I still have other things to fix in that area.

Harri, if you like you can go ahead and start adding shaders to improve the performance of OGL3, that is why I added the shaders folder a long time ago, our plans however are to integrate the CG shader compiler, so you might want to wait.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) The 11th plague of Egypt
Reply #13 Posted on: August 31, 2013, 04:12:49 PM
Member
Joined: Dec 2009
Posts: 276

View Profile
Lol, this is the funniest discussion on commits breaking things I've ever seen!

It's good to see things discussed in the open. :D
Logged
Offline (Male) Goombert
Reply #14 Posted on: August 31, 2013, 04:25:24 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3110

View Profile
Yes we like transparency and freedom of speech here.
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Pages: 1
  Print