Pages: « 1 2 3
  Print  
Author Topic: Proposal for guidelines on changes to the master branch of enigma-dev/enigma-dev  (Read 7163 times)
Offline (Male) Goombert
Reply #30 Posted on: June 08, 2013, 05:19:57 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3017

View Profile
forthevin, I want you to add two things to this.

1) When making bug reports, people should include exact steps to replicate, and properly label issues on the tracker, take LGM's tracker as an example, I had a very pleasant experience working with IsmAvatar's tracker. ENIGMA's tracker on the other hand is a complete mess, when we implement stuff or fix bugs we never mark off the issue # the commit fixes or anything like that, that I was doing on LGM's tracker, not to mention we have polygonz in charge of labeling ^_^

2) When merging I think we need to add that people should make an effort to understand the code and actually review it before merging. It is like writing an essay, you can't proof read your own stuff well, it is best when someone else does it for you. This is also one of the big things of having SVN and a tracker, but yet we do not utilize it, even Josh has done this by merging cheeseboy's half broken code without reviewing that I had to go fix immediately for him.
« Last Edit: June 08, 2013, 05:22:59 PM by Robert B Colton » Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Offline (Unknown gender) forthevin
Reply #31 Posted on: June 10, 2013, 02:49:59 PM

Contributor
Joined: Jun 2012
Posts: 167

View Profile
Hey Robert, I think you have some good suggestions. I have added a bit to the wiki in regards to the exact steps to replicate on the page about bug reporting, and I have made a new page on working with issues in GitHub. About reviewing changes, that part is actually already in the guidelines on changing.
Logged
Offline (Male) Goombert
Reply #32 Posted on: June 10, 2013, 03:36:14 PM

Developer
Location: Cappuccino, CA
Joined: Jan 2013
Posts: 3017

View Profile
Wonderful forthevin! Thanks for all your help, I have already taken to doing so as well, tracker looks better already  (Y)
Logged
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.

Pages: « 1 2 3
  Print