ENIGMA Forums

General fluff => General ENIGMA => Topic started by: polygone on August 24, 2013, 08:05:06 PM

Title: Warnings
Post by: polygone on August 24, 2013, 08:05:06 PM
There's always endless warnings that crop up when compiling. I think as developers we should have a new mandate that instead of ignoring them we should resolve them whenever we see one instead of just always ignoring them. This is the only way I think they will get weeded out of the source.
Title: Re: Warnings
Post by: polygone on August 24, 2013, 08:44:58 PM
Speaking of something related. Does anybody know why the plugin is passing all true booleans as -1 instead of 1? It's not making any difference to the outcome but it's rather dodgy and throws warnings everywhere. It's doing it in all the game settings and room settings and such.
Title: Re: Warnings
Post by: Goombert on August 24, 2013, 09:52:19 PM
Yes we do need to do some warning cleanup you already know that slows down compiling, lots of them are probably my fault I have been ignoring quite a few. But what do you mean the plugin is passing -1's?
Title: Re: Warnings
Post by: polygone on August 24, 2013, 09:56:07 PM
Check the output of settings or room array in preprocessor whenever ever there is a boolean variable that's set to true it's printed as -1.
Title: Re: Warnings
Post by: Goombert on August 24, 2013, 10:07:16 PM
Idk plionz, GMX stores boolean true as -1 :P
Title: Re: Warnings
Post by: polygone on August 24, 2013, 10:18:03 PM
It's sending values of -1 with a blank game as well. -Oh because LGM sets them to -1 also in order to be compatible with GM. But LGM should set them all boolean before sending to the plugin.
Title: Re: Warnings
Post by: Goombert on August 24, 2013, 10:50:28 PM
https://github.com/enigma-dev/enigma-dev/pull/352

Merge that joystick and exe fix polygonz, enigma.exe now needs settings.ini for which the code is this...

Code: [Select]
[MAIN]
setupcompleted=1
checkforjava=0
redirectoutput=1

Delete the file called compiled, and you can set that to 1 there if you already set up ENIGMA. I've uploaded the new zip already.
Title: Re: Warnings
Post by: polygone on August 24, 2013, 11:32:33 PM
This has nothing to do with the warnings...