Next topic

[egofree]

And let's not forget the room's 'creation code' and 'instance creation code' ! 

[polygone]

Is that a 'no' on moving it below the resource tree then?

[TheExDeus]

Technically it should be a toolbar as any other. Then you could drag it to the bottom, the side or just hide it. Putting it in a static place will never please everyone, but most people will get used to it.

[Goombert]

Is that a 'no' on moving it below the resource tree then?

It's an I don't know because you haven't provided any argument as to why it should be in a place inconsistent with 99% of applications besides GM: Studio.

Technically it should be a toolbar as any other. Then you could drag it to the bottom, the side or just hide it. Putting it in a static place will never please everyone, but most people will get used to it.

It is a toolbar in order to render the buttons the way that it does, it's just not set floatable because if I recall I believe it wouldn't work for some reason, because it's not set like a regular toolbar on a frame and I also felt that it looked a little tacky as floatable.

I'll take a look and see if setting it floatable will work, I will also make the Event Selector button and stuff on the object frame focus the Events tab which is something else I forgot about. We honestly need a proper docking framework.

[IsmAvatar]

Upon further review of the GPLv2 (and discussion with Josh), I retract my request to revert the introduction of GPL2 code (specifically the modified RTF Editor code). The code can stay.

GPLv2 section 6:

Each time you redistribute the Program (or any work based on the Program), the recipient automatically receives a license from the original licensor to copy, distribute or modify the Program subject to these terms and conditions. You may not impose any further restrictions on the recipients' exercise of the rights granted herein. You are not responsible for enforcing compliance by third parties to this License.

This means that the code must remain GPLv2 only and modifications to it must remain GPLv2 as well. However, the code can still become a part of LateralGM as that prohibition was not made until GPLv3 (with the "tivo" clause).

I look forward to release.

[Goombert]

Alright another update with several suggestions taken from your feedback.

* The search filter toolbar is now floatable.
* The modify or event button will now raise the events tab if it is docked.
* I took egofree's feedback and you can no longer search an expression that is zero in length, so you have to actually enter something before you can perform a search.
* You can now search all the arguments of every drag and drop action, instance creation code, and room creation code.
* You can now click on the moment, event, action, and other nodes and have them open the appropriate code editor or select the right moment or event, etc. For instance if you click the draw event the object frame opens with the draw event in focus, if you click a child action the code frame will also appear.
* Fixed an issue with the match line numbers, they were starting at 1 and the code editor starts 0.
* Fixed an exception that would occur when hovering over a resource menu.

So the search feature is basically finished and I would just appreciate it if you guys could test for bugs. The jars can be obtained from the Extra Packages page.
http://enigma-dev.org/docs/Wiki/Install:Extra_Packages

[egofree]

The search feature is almost perfect. I see only one missing feature : scope doesn't seem to be implemented. Within scripts, would it be possible to select the corresponding line ? (In the code editor, when you select a line with the cursor, it becomes blue. That would be fine)

[egofree]

Ok, i've found a bug. In an object event, i add a new script with the line 'game_state=FINISHED'. I do a search for the keyword game_state. I close the object window, without saving it. Then in the search result tree, i open the line and i get the following exception :

Operating System: Linux
Version: 3.11.0-12-generic
Architecture: amd64

Java Vendor: Oracle Corporation
Version: 1.8.0_05

Available processors (cores): 8
Free memory (bytes): 31972920
Maximum memory (bytes): 3717201920
Total memory available to JVM (bytes): 101711872

File system root: /
Total space (bytes): 949974736896
Free space (bytes): 792519688192
Usable space (bytes): 744240156672

Stack trace:
java.lang.NullPointerException
   at org.lateralgm.components.ActionList.openActionFrame(ActionList.java:201)
   at org.lateralgm.main.LGM$SearchResultNode.openFrame(LGM.java:1813)
   at org.lateralgm.main.LGM$SearchResultNode.openFrame(LGM.java:1797)
   at org.lateralgm.main.LGM$5.mouseReleased(LGM.java:2107)
   at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$400(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

This means we try to open a line which was not saved.

[Goombert]

Sorry about that egofree I have patched the exception now. Opening search result nodes should also focus the correct line in the code editor or focus the entry/text area of the correct argument on the corresponding action frames for all resources.

The search feature could not get any better, we just need to test for bugs now, so please go test the new jars.
http://enigma-dev.org/docs/Wiki/Install:Extra_Packages

https://github.com/IsmAvatar/LateralGM/commit/f3c470d6d94a9b0549e26763366c0cf1d718d338
https://github.com/IsmAvatar/LateralGM/commit/246f954c2fcec70c22e4ca25ff102ca99518caad
https://github.com/IsmAvatar/LateralGM/commit/3a7daf6609d938c7b5ff191d78b9d068c56e3702
https://github.com/IsmAvatar/LateralGM/commit/6d7d7da334d5b5ee7184a0db28e503d1058648e6
https://github.com/IsmAvatar/LateralGM/commit/45d9bc85514d595644b61f6b10743dd6a56fb6e0

[egofree]

Thanks Robert for all your effort. I feel we are very close to the next release. I just found a small glitch : in the 'Search results' tree, when you open a new script window, and this window has scroll-bars, the line is not visible. It is just below the 'viewport'. I post a screenshot, i think it will be clearer :



As you can see, i tried to open line 34 for the object obj_HUD, but the line is not visible. We have to scroll down the window in order to see the selected line. This problem doesn't occur if the window is already open.

Edit:
If there is already a script window open and maximized, when you try to open another window it will be also maximized and you will not have this problem.

[egofree]

If i try to open a result with a 'set variable' action, i get the following error :

Operating System: Windows 7
Version: 6.1
Architecture: x86

Java Vendor: Oracle Corporation
Version: 1.8.0_25

Available processors (cores): 8
Free memory (bytes): 175515032
Maximum memory (bytes): 1013645312
Total memory available to JVM (bytes): 259588096

File system root: C:\
Total space (bytes): 1017834733568
Free space (bytes): 727100559360
Usable space (bytes): 727100559360

File system root: D:\
Total space (bytes): 0
Free space (bytes): 0
Usable space (bytes): 0

Stack trace:
java.lang.NullPointerException
   at org.lateralgm.main.LGM$SearchResultNode.openFrame(LGM.java:1865)
   at org.lateralgm.main.LGM$5.mouseReleased(LGM.java:2210)
   at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$400(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

[Goombert]

Alright, new update available for download.

Download: http://enigma-dev.org/docs/Wiki/Install:Extra_Packages

* Fixed the exception egofree encountered, I was checking for code actions the wrong way.
https://github.com/IsmAvatar/LateralGM/commit/e7aa42d20017f48fb57a75250cef8c9158b97e3c
* Josh added caret focus functionality to JoshEdit so your second issue egofree is no more.
https://github.com/IsmAvatar/LateralGM/commit/ad4906e7975d50c647771457d1f228970e42d61d
* Added preferences to change the search highlighting colors, or disable the background or foreground or all highlighting respectively. You can also now set the two colors used to render the checkerboard background on the background and sprite image previews.
https://github.com/IsmAvatar/LateralGM/commit/2604155527be360423129a5c6f376bbe459f476c
* Included a new dark theme friendly icon pack derived from Calico called "Contrast" The look and feel being used in the screenshot below is Synthetica which you can find in my other topic.
http://enigma-dev.org/forums/index.php?topic=2283.0
* Fixed an issue where certain look and feels would cause the main frame to overlap the toolbar on Windows on some platforms, and yes this also includes the default Swing look and feel. https://github.com/IsmAvatar/LateralGM/commit/3329a3abbae19f6bdaa0d7df6ea841119acb1690
* You can also use a custom background image for LGM's window area now, create a file called "lgmbackground.png" in the "lookandfeels" folder next to lateralgm.jar and the image should be applied during the splash screen when you load. The following is a link to LGM's dark background.
https://github.com/IsmAvatar/LateralGM/commit/eb8fd916690fc17098fab6ef189f785261902efb
https://github.com/IsmAvatar/LateralGM/blob/master/org/lateralgm/main/lgmbackgrounddark.png

Click the link above or Right Click->View Image to download this image and apply it to LGM's background.

[Darkstar2]

Never thought I'd say this but I like the theme in the last image lol! I wonder what it reminds me of

[Goombert]

Darkstar2, you can't possibly mean GM: Studio's because LateralGM's beats the hell out of their dark theme.   

Another update with some more bugfixes that were introduced along the way.

* Code completion should work again, Josh mistakenly forgot to implement HasKeywords on GMLTokenMarker
* Room editor File->Close button should work now, it got disabled under confusion of its purpose during my earlier refactors to fix reverting.
* The error dialog was never supposed to be editable, it no longer is but you can still copy it to the clipboard and it still shows the caret.
https://github.com/IsmAvatar/LateralGM/commit/dac8b911ad74131189f6c767e8023827f830330e

[egofree]

A picture is worth a thousand words : 





Thanks a lot Robert for implementing this very useful function. Time to release ! From my point of view, we should post an announce. For several months, LateralGM has improved a lot, and i am sure people would be interested to know this.

Edit:
If i change the 'Background color' for the 'Result matches', the search toolbar disappears. Is this normal ?