Menu

Show posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Show posts Menu

Messages - polygone

#436
Proposals / globalvar
March 05, 2011, 04:11:30 PM
globalvar to global var macro needed. Already known just referencing.


Tracker Reference:
http://enigma-dev.org/tracker/ticket.php?id=91
#437
xprevious / yprevious should be changed whenever an instance's x / y variable is changed.


Tracker Reference:
http://enigma-dev.org/tracker/ticket.php?id=88
#438
propogate_locals is current called at the start of each instance's step event. However for compatibility a separate pass should be made for this after the step event.


Tracker Reference:
http://enigma-dev.org/tracker/ticket.php?id=87
#439
Proposals / Re: 2 bugged GM files
March 05, 2011, 08:13:02 AM
I have been trying to debug this myself. I have found that the result of this bug is actually due to two issues:

1) background_showcolor is not used

In roomsystem.c background_color is defined using:

Code (C++) Select
background_showcolor = (backcolor!=-1);
Instead of from the background_showcolor boolean from LGM.

Note that when this is fixed GSscreen.cpp also needs updating. It uses (in 2 places):

Code (C++) Select
      if (background_showcolor)
      {
         int clearcolor=((int)background_color)&0xFFFFFF;
         glClearColor(__GETR(clearcolor)/255.0,__GETG(clearcolor)/255.0,__GETB(clearcolor)/255.0, 1);
         glClear(GL_COLOR_BUFFER_BIT);
      }

An else statement should be added to this clearing the screen in black (as GM does).


2) The instance's parent draw code is not being executed in my particular file.

EDIT: No longer a problem.
#440
Proposals / Parenting
March 05, 2011, 07:57:06 AM
Parenting events is currently not implemented.
#441
Proposals / Re: room_speed
March 04, 2011, 07:52:46 PM
Oh I see what it's doing now, I misunderstood it's purpose.
#442
Proposals / Re: room_speed
March 04, 2011, 06:14:14 PM
edit: nevermind
#443
Proposals / Re: Function approval process
March 03, 2011, 05:18:31 PM
OK so is this set to go then? I want to make sure we can actually sort something out because I believe it is necessary to help drive progress.

So the first thing needed is to populate the function list on wiki. Are you working on this TGMG?
#444
Proposals / Re: Action functions plugin writing
March 03, 2011, 03:13:46 PM
I don't get? Isn't it just better to pass it as an argument anyway? It seems preferable for function calling.
#445
Function Peer Review / Re: action_move_to
March 02, 2011, 09:22:46 PM
Oh using a default parameter is fine then?

Code (C++) Select
inline void action_move_to(double x, double y, bool argument_relative = false)
{
  enigma::object_planar* const inst = ((enigma::object_planar*)enigma::instance_event_iterator->inst);
  if (argument_relative)
  {
    inst->x += x;
    inst->y += y;
  }
  else
  {
    inst->x = x;
    inst->y = y;
  }
}

You won't need argument_relative as a global variable then. Why wasn't this just used to start with?
#446
Function Peer Review / Re: action_move_to
March 02, 2011, 07:36:36 PM
I'm failing to see how it will work without overcomplicating things since when the gml action_* functions don't take the relative argument.
#447
Function Peer Review / Re: action_move_to
March 02, 2011, 04:40:32 PM
QuoteSo it needs to keep track of where to actually close the '{' for action_if's (that have the relatvie checkbox) which is much more complex than passing the value in by the argument.
Can't you put the closing brace in then move back up into the statements?
#448
Function Peer Review / Re: action_move_to
March 02, 2011, 06:08:05 AM
I've just seen in Universal System:
https://enigma-dev.svn.sourceforge.net/svnroot/enigma-dev/trunk/ENIGMAsystem/SHELL/Universal_System/actions.h

I'm presuming this isn't actually called, but will be?
#449
Function Peer Review / Re: action_move_to
March 02, 2011, 04:50:28 AM
So I see, you would work relative like so EDL:

Code (EDL) Select
argument_relative = true;
action_move_to(4, 4);

Should use the action relative. This I presume would actually work in gml however it doesn't allow you to set the argument_relative variable.

Calling plain as:
Code (EDL) Select
action_move_to(4, 4);
Should always use the action not relative. This means that the argument_relative variable should always be set false after an action is called.
#450
Proposals / Re: Action functions plugin writing
March 02, 2011, 04:31:00 AM
Why are the argument_* global variables a different scope to the rest of the global variables? I can't use them inside function definitions...