ENIGMA Forums

General fluff => General ENIGMA => Topic started by: Goombert on January 19, 2016, 03:15:30 am

Title: Stable Branch/lgm16b5
Post by: Goombert on January 19, 2016, 03:15:30 am
I am introducing a stable branch to LateralGM which only pulls in the most important fixes on top of lgm16b4. This version is not concerned with changing the look and feel and other aesthetic enhancements. It is concerned with code quality and functionality. It is mainly targeted at those who want a more stable LateralGM without all the bells and whistles that sometimes don't even whistle.

My commits are first introduced on page 24 at https://github.com/IsmAvatar/LateralGM/commits/082952ab9ec15fedab120197e770e0c393fccf71?page=24

Reasons to break support for older Java versions:
* getSelectedValues() is deprecated in favor of getSelectedValuesList() as of JDK 1.7 and these methods are used in ActionList
* SwingWorker was added in JDK 1.6

The first issues on this list are possible, but are considered to be less important or controversial:
https://github.com/IsmAvatar/LateralGM/issues/233
https://github.com/IsmAvatar/LateralGM/issues/184
https://github.com/IsmAvatar/LateralGM/issues/181
https://github.com/IsmAvatar/LateralGM/issues/163
https://github.com/IsmAvatar/LateralGM/issues/159
https://github.com/IsmAvatar/LateralGM/issues/147
https://github.com/IsmAvatar/LateralGM/issues/143
https://github.com/IsmAvatar/LateralGM/issues/27

These changes are not controversial, they are the first that should be done:
https://github.com/IsmAvatar/LateralGM/blob/d038ba5fd21ddf24a62a4bf968ed35f10f93de86/org/lateralgm/components/AboutBox.java#L117
https://github.com/IsmAvatar/LateralGM/issues/232
https://github.com/IsmAvatar/LateralGM/issues/230
https://github.com/IsmAvatar/LateralGM/issues/158
https://github.com/IsmAvatar/LateralGM/issues/144
https://github.com/IsmAvatar/LateralGM/issues/93
https://github.com/IsmAvatar/LateralGM/issues/90
https://github.com/IsmAvatar/LateralGM/issues/59
https://github.com/IsmAvatar/LateralGM/issues/52
https://github.com/IsmAvatar/LateralGM/issues/24
https://github.com/IsmAvatar/LateralGM/issues/21
https://github.com/IsmAvatar/LateralGM/commit/4020882b91a8a73fa430c5927b683daf73fc9166
https://github.com/IsmAvatar/LateralGM/commit/3f667d4ca20ed5c92aeb9862a00f9d3d2e99231b
* Add shortcuts for Bold, Italic, Underline, and Alignment in Game Info editor.
* Add missing tooltips for toolbar buttons in game info/room editors.
* Change default Background color to white.
* Always asking to save changes, b4 regression. Likely the result of logical equality changes.

Being worked on:
https://github.com/IsmAvatar/LateralGM/issues/306
https://github.com/IsmAvatar/LateralGM/pull/272
https://github.com/IsmAvatar/LateralGM/pull/268
https://github.com/IsmAvatar/LateralGM/issues/263
https://github.com/IsmAvatar/LateralGM/issues/165
* Closing the object/timeline frame or the action container does not close all open actions.
https://github.com/IsmAvatar/LateralGM/issues/171

Cherry pick IsmAvatar commits:
https://github.com/IsmAvatar/LateralGM/pull/44
* Can't open the same type of action frame twice and new actions are not selected because of logical equality.

Completed items:
https://github.com/IsmAvatar/LateralGM/pull/291
https://github.com/IsmAvatar/LateralGM/pull/269
https://github.com/IsmAvatar/LateralGM/pull/264
https://github.com/IsmAvatar/LateralGM/pull/262
https://github.com/IsmAvatar/LateralGM/pull/261
https://github.com/IsmAvatar/LateralGM/pull/260

https://github.com/IsmAvatar/LateralGM/pull/251
https://github.com/IsmAvatar/LateralGM/pull/249
https://github.com/IsmAvatar/LateralGM/pull/248
https://github.com/IsmAvatar/LateralGM/pull/247
https://github.com/IsmAvatar/LateralGM/pull/244
https://github.com/IsmAvatar/LateralGM/pull/243
https://github.com/IsmAvatar/LateralGM/pull/242
https://github.com/IsmAvatar/LateralGM/pull/241
https://github.com/IsmAvatar/LateralGM/pull/240
https://github.com/IsmAvatar/LateralGM/pull/239
https://github.com/IsmAvatar/LateralGM/pull/238
https://github.com/IsmAvatar/LateralGM/pull/237
https://github.com/IsmAvatar/LateralGM/pull/236
https://github.com/IsmAvatar/LateralGM/pull/235
https://github.com/IsmAvatar/LateralGM/commit/7a1acc1e419e993b02a2212f33eb5144497d8ca0

Fixed by original maintainers (we want to branch from after these were fixed):
https://github.com/IsmAvatar/LateralGM/pull/36
https://github.com/IsmAvatar/LateralGM/issues/32
https://github.com/IsmAvatar/LateralGM/issues/11
https://github.com/IsmAvatar/LateralGM/issues/10
https://github.com/IsmAvatar/LateralGM/issues/9
https://github.com/IsmAvatar/LateralGM/issues/7
https://github.com/IsmAvatar/LateralGM/issues/4
https://github.com/IsmAvatar/LateralGM/issues/3
https://github.com/IsmAvatar/LateralGM/issues/2