ENIGMA Forums

General fluff => General ENIGMA => Topic started by: Goombert on September 08, 2014, 06:27:20 pm

Title: Search Filter
Post by: Goombert on September 08, 2014, 06:27:20 pm
Well this was just something I wanted to experiment with today, saw it in the new Studio and really liked the feature so I spent all day coding it and perfecting it to make sure there were no glitches. Functions pretty well and just about the same as Studio and is easily expandable for more capabilities such as regular expressions and case sensitivity. I optimized the searching/filtering as best I could as well so you should expect it to work pretty efficiently.

(http://i.imgur.com/Z7r3KEU.png)

There are a couple of differences to note however. In the ENIGMA version if you have focus on the search filter and hit enter the selected resource is automatically opened in its editor, Studio does absolutely nothing so I just thought this was a nice little addition. I would appreciate it if everyone could test this new feature and give me some feedback or let me know of any errors encountered and whether or not you like the feature. If everyone likes it and it works out well I will send the changes upstream.

Edit: Changes stable and sent upstream.

This was the commit.
https://github.com/IsmAvatar/LateralGM/commit/d7abae97c3aa06be7c6a5fbfa2e3e80e22e5e91d

The LateralGM version has been incremented to 1.8.6 and also includes egofree's room editor improvements.
The new LGM can be obtained via the extra packages page or through the python script.
http://enigma-dev.org/docs/Wiki/Install:Extra_Packages#LateralGM
A new Portable is also available for download.
http://enigma-dev.org/docs/Wiki/Install:Windows
Title: Re: Search Filter
Post by: sorlok_reaves on September 08, 2014, 08:12:14 pm
Looks great! This will be perfect for games with tons of objects/scripts.
Title: Re: Search Filter
Post by: Darkstar2 on September 08, 2014, 08:33:01 pm
That was quick :D

Thanks, will try it later.

But we do have a find resource under resource menu,

(ctrl-alt-f) in ENIGMA, doesn't it do much the same ?
Title: Re: Search Filter
Post by: Goombert on September 08, 2014, 11:33:43 pm
This one gives much quicker results though and you can visually see them as well as filter the resources as you go so it's more like a file explorer. I personally like this feature much better because the other feature just stops at the first resource it is kind of archaic but I see no reason to remove that feature for the time being.

Also I forgot to mention that in Studio if you filter the tree and try to duplicate one of the resources that Studio will error lol but LGM does not you can duplicate filtered resources but the filter may not immediately update and show the duplicated resource even if it don't match the expression.
Title: Re: Search Filter
Post by: sorlok_reaves on September 08, 2014, 11:58:53 pm
I think (at least for objects) duplicated objects will eventually fail on compile, due to duplicate definitions (C++-level). I imagine duplicates of anything else would fail when compiling resource the lookup maps (but haven't tried it).
Title: Re: Search Filter
Post by: Goombert on September 09, 2014, 12:07:03 am
Oh no sorlok that is not what I meant. Duplicate ID checking is another issue we need to resolve, but I am talking about right clicking the resources when the filter is active and duplicating one of them in which case they are automatically assigned a new name and they may still be visible even if that name does not apply to the filter unless you change the filter or toggle it on and off real fast. I am wondering if maybe I should make renaming of a node automatically trigger an update to the filter.
Title: Re: Search Filter
Post by: sorlok_reaves on September 09, 2014, 12:15:49 am
Ah, now I see.

I guess... for correctness, you should fix it, but for practicality it probably isn't a big deal.
Title: Re: Search Filter
Post by: Goombert on September 09, 2014, 01:18:49 am
All changes are now upstream! I fixed the last remaining bug and everything is good.
Title: Re: Search Filter
Post by: TheExDeus on September 09, 2014, 04:08:39 am
I would love a search feature to search in all the code. So I could find a variable that is causing problems without going manually trough all the objects and their events.
Title: Re: Search Filter
Post by: Goombert on September 09, 2014, 10:03:42 am
I'll see what I can do Harri but do not expect it right away.
Title: Re: Search Filter
Post by: Darkstar2 on September 09, 2014, 11:05:55 am
I would love a search feature to search in all the code. So I could find a variable that is causing problems without going manually trough all the objects and their events.

Searching in all code, now that would be fantastic :D
Title: Re: Search Filter
Post by: egofree on September 09, 2014, 02:11:13 pm
Thanks for adding new features in LateralGm Robert. If i can give my 2 cents : i don't think the search filter should be displayed by default. I would be prefer a dialog window.
Title: Re: Search Filter
Post by: Goombert on September 09, 2014, 02:19:31 pm
Well we can look at adding a setting to disable it, but I still think it should be enabled by default Unity3D has one of these and it's very useful I would venture most people would find it useful. But that's merely a matter of preference. So first I would like you to take a look at my new post with the redesign of the settings interfaces first before I go adding new settings.
http://enigma-dev.org/forums/index.php?topic=2220.0

Second, I also think we could add a "Search in Resource" capability to this search filter. Let me explain, in Windows Explorer if you search for something Windows will search in the actual files and not just the name of the file. This would even save you the time of going to a separate search in scripts interface, though one would still be added for more refined searches. But I am proposing this mainly to Harri.
Title: Re: Search Filter
Post by: TheExDeus on September 09, 2014, 05:58:41 pm
On windows you often have to write "Content: my_variable" to search "my_variable" inside txt files. But if you don't type that it will search inside files as well, but only after finishing with filenames. Anyway, I would love searching in all resource whatever the window/tab it's in. We can always move stuff, but we need to code the thing first.
Title: Re: Search Filter
Post by: Goombert on September 09, 2014, 06:54:37 pm
Ok but let me finish up the current thing I am working on with merging ENIGMA settings. Also egofree I've added a setting for you to disable the filter in the preferences window, when my newest changes go upstream you can update.