Next topic

[Goombert]

Ok guys, now that I got all the common headers in all systems merged together removing bout 3100 duplicate lines of code. We need to switch all the draw functions in Graphics Systems to take float where previously they took double.

Code Select Expand

draw_text(double x, double y, string str);
becomes...

Code Select Expand

draw_text(float x, float y, string str);

As OpenGL does not work in precision higher than float. Wherever you see like x or yscale they should also be switched. Width and height for images should remain as integer.

[TheExDeus]

Well they are cast anyway, so I doubt it will improve much (unless casting from double to float is extremely slow for some reason). Scaling could slightly gain from having be in double as it is not actually used in GL directly, but is used to calculate vertex positions. Of course when the positions are then used and cast to float then I guess most of the gain is lost. Anyway, I don't think it's that hard and you should do it, as it will be chaos if everyone tried to changed that. Unless you don't want to and then I guess I can do that.

[Josh @ Dreamland]

The improvement is that the cast is done by the user as needed. If the user has a float already, no cast is required.

[Goombert]

Harriy, I can do it, I am very good at the monotonous kind of work

[Goombert]

Finished, tested, and ready to be merged.
https://github.com/enigma-dev/enigma-dev/pull/267