Next topic

[polygone]

Code (C++) Select Expand

inline void action_move_to(double x, double y)
{
  enigma::object_planar* const inst = ((enigma::object_planar*)enigma::instance_event_iterator->inst);
  if (argument_relative)
  {
    inst->x += x;
    inst->y += y;
  }
  else
  {
    inst->x = x;
    inst->y = y;
  }
}
How the fuck does relative work? It isn't specified as an argument in gml....

[RetroX]

Code Select Expand

inline void action_move_to(double x, double y) { move_towards_point(x, y); }

[Rusky]

argument_relative

[RetroX]

Code Select Expand

void action_move_to(double x, double y, bool argument_relative)
{
  enigma::object_planar* const inst = ((enigma::object_planar*)enigma::instance_event_iterator->inst);
  if (argument_relative)
  {
    inst->x += x;
    inst->y += y;
  }
  else
  {
    inst->x = x;
    inst->y = y;
  }
}

[IsmAvatar]

It's codematically generated when The Plugin translates your DND to code. Immediately prior to the code it will set argument_relative to true if it's relative, or false otherwise.

[polygone]

I meant when using action_ functions. In gml the relative argument doesn't seem to be used..

[IsmAvatar]

No, I don't think relative is treated as an argument. Instead, it's treated as an internal mechanism, probably not unlike how we've implemented it as a kind of global variable.

[TGMG]

This is not the best place to report this but before I forget (I was going to investigate further before filing a bug report). but there is a serious problem with the way the enigma plugin writes the action code.
Before it calls any action it writes the code "argument_relative=true; action_whatever()". Which works fine normally but it doesn't work when the if action is used without the block actions! as this happens:
"if (false) argument_relative=true; action_whatever()"
So it still calls action_whatever even although it shouldn't. I think a similar thing happens with the "with" statement.

It might be better to pass argument_relative into the function as a parameter that has a default value (so it is optional incase its used in normal gml).

[polygone]

So I see, you would work relative like so EDL:

Code (EDL) Select Expand

argument_relative = true;
action_move_to(4, 4);
Should use the action relative. This I presume would actually work in gml however it doesn't allow you to set the argument_relative variable.

Calling plain as:

Code (EDL) Select Expand

action_move_to(4, 4);
Should always use the action not relative. This means that the argument_relative variable should always be set false after an action is called.

[IsmAvatar]

Yes, that's exactly the way it works.
In fact, at one point I had forgotten to reset argument_relative, so we had a bug, but it has since been fixed.
Actually, the way we handle it is to *always* set argument_relative prior to any action that allows relative. Maybe not the most efficient, but I don't think DND users are going to complain about an additional variable set before some DND actions.

However, as TGMG has pointed out, using an IF action before a relative action causes a problem with this conversion method:
* If Action
* Set Motion Relative

gets converted to:

Code Select Expand

if (blah)
  argument_relative = blah;
action_set_motion(blah);

Even though action_set_motion should belong to the if statement.
Solved by either:

Code Select Expand

if (blah)
  { argument_relative = blah; action_set_motion(blah);
or

Code Select Expand

if (blah)
  action_set_motion(blah,argument_relative_value);

[polygone]

I've just seen in Universal System:
https://enigma-dev.svn.sourceforge.net/svnroot/enigma-dev/trunk/ENIGMAsystem/SHELL/Universal_System/actions.h

I'm presuming this isn't actually called, but will be?

[TGMG]

@IsmAvatar I initially tried to solve the problem by changing the plugin to add "{" around it. But it causes a problem when using multiple if statements:
{argument relative=false //this argument_relative is part of the action_if_something
if(action_if_something()) { //can't close the '}' for argument_relative until the end
{argument relative=false //this argument_relative is part of the action_if_something
if(action_if_something()) {
{argument relative=false
if(action_if_something()) {
{argument relative=false
action_something();}
}}}}}} //close al the if statements and the argument_relative blocks

So it needs to keep track of where to actually close the '{' for action_if's (that have the relatvie checkbox) which is much more complex than passing the value in by the argument.

@polygone: I forgot that file was still in enigma, it isn't included, it provides all the function prototypes so i can easily test out game maker games which use actions without actually implementing each action properly. As you can see its very messy and unoptimised, it was really just a way to quickly test games that otherwise wouldn't convert.

[polygone]

So it needs to keep track of where to actually close the '{' for action_if's (that have the relatvie checkbox) which is much more complex than passing the value in by the argument.

Can't you put the closing brace in then move back up into the statements?

[TGMG]

I don't understand what you mean by moving back up into the statements :/

[Rusky]

Keeping track of braces is trivial if you're not doing a find-and-replace parser, which I hope is the case by now.