Pages: 1
  Print  
Author Topic: Methods setRoomPosition and getRoomPosition need to be updated in the lgm plugin  (Read 1402 times)
Offline (Unknown gender) egofree
Posted on: June 30, 2014, 01:20:39 pm
Contributor
Joined: Jun 2013
Posts: 601

View Profile Email
In LateralGm i've added in the interface 'Piece' the methods setPosition and getPosition. The Instance class had already these methods, but the tiles methods names were slight different : setRoomPosition and getRoomPosition, so i renamed these methods, but i forgot to update these methods in the egm file reader and writer in the lgm plugin.

I've fixed this error, and made already the following pull request :
https://github.com/enigma-dev/lgmplugin/pull/23
« Last Edit: June 30, 2014, 01:25:33 pm by egofree » Logged
Offline (Unknown gender) Darkstar2
Reply #1 Posted on: June 30, 2014, 02:13:04 pm
Member
Joined: Jan 2014
Posts: 1238

View Profile Email
BTW you deserve credit when you contribute fixes or new features, you should modify the about area with your name.  You've done it in the source code but you forgot to modify the about. :)

BTW, and this is a question to all devs, shouldn't new revisions of LGM (bug fixes, new features, etc.) increment its version value ?  It's been stuck at 1.85.  Usually software company increment versions even on smaller updates.   Fractional increments for small changes and whole increment for significant changes.  So for example shouldn't this really be 1.86 ?

Logged
Offline (Unknown gender) egofree
Reply #2 Posted on: July 01, 2014, 03:37:21 am
Contributor
Joined: Jun 2013
Posts: 601

View Profile Email
BTW you deserve credit ..

Is it all worth it? :  :D

Quote
Our revels now are ended. These our actors,
As I foretold you, were all spirits and
Are melted into air, into thin air:
And, like the baseless fabric of this vision,
The cloud-capp'd towers, the gorgeous palaces,
The solemn temples, the great globe itself,
Ye all which it inherit, shall dissolve
And, like this insubstantial pageant faded,
Leave not a rack behind. We are such stuff
As dreams are made on, and our little life
Is rounded with a sleep.
Logged
Offline (Unknown gender) Darkstar2
Reply #3 Posted on: July 01, 2014, 12:32:25 pm
Member
Joined: Jan 2014
Posts: 1238

View Profile Email
Not a question of worth it or not, but for legal reasons, you want to protect your work and not have someone else take credit for it.  :D

Logged
Pages: 1
  Print