move_wrap

[polygone]

Code: (C++) [Select]

void move_wrap(bool hor, bool vert, double margin)
{
  enigma::object_planar* const inst = ((enigma::object_planar*)enigma::instance_event_iterator->inst);
  if (hor)
  {
    const double wdis = room_width + margin*2;
    if (inst->x < -margin)
    {
      inst->x += wdis*ceil(((-margin) - inst->x)/wdis);
    }
    if (inst->x > room_width + margin)
    {
      inst->x -= wdis*ceil((inst->x - (room_width + margin))/wdis);
    }
  }
  if (vert)
  {
    const double hdis = room_height + margin*2;
    if (inst->y < -margin)
    {
      inst->y += hdis*ceil(((-margin) - inst->y)/hdis);
    }
    if (inst->y > room_height + margin)
    {
      inst->y -= hdis*ceil((inst->y - (room_height + margin))/hdis);
    }
  }
}

Post made March 01, 2011, 09:47:03 am was deleted at the author's request.

[polygone]

I. Did. This. One. FFS.

And more efficiently.

Code: (Something that looks like C++ and is easily portable) [Select]

//int move_wrap(double hor,double vert,double margin)
int move_wrap(double hor,double vert,double margin) {
  //not sure whether two IFs are faster than one big calculation in a single IF
  if (hor) {
    if (X < -margin || X > room_width+margin) {
      X = -(X-room_width);
    }
  }
  if (vert) {
    if (Y < -margin || Y > room_height+margin) {
      Y = -(Y-room_height);
    }
  }
  return (int)0;
}
Since Josh fails to remember or care (<_<), I post this code.

a) That's not more efficient, it's different. And by being different it does not behave how the function behaves in GM. I don't just stick shit into code randomly
b) It's not written properly. Wtf are X and Y going to do?

[RetroX]

Dear Fede-lasse,

Please do not complain that you have already done functions when you posted them months ago and we don't know where they are.

If you wish to have them actually looked at, please post them or point out where you posted them.

Sincerely,
RetroX and everyone else.

P.S.: (int)0 is redundant because 0 is an int, and it would have been auto-casted either way.

Post made March 06, 2011, 03:05:42 pm was deleted at the author's request.

[polygone]

I never said it was less efficient, I said it was different. My code is 'less efficient' for a reason: because it works better.

Post made March 08, 2011, 03:54:57 am was deleted at the author's request.

[polygone]

My version mimics the behaviour in GM, so I don't see the problem.

It doesn't mimic the behaviour in GM. Try moving an instance's x position 3*room_width and see if it wraps correctly using your code. If you actually read what code I use you will see I am specifically catering for this.

Though actually my code doesn't completely mimic GM's, it in fact works better. I believe GM's code goes more like this:

Code: [Select]

  if (hor)
  {
    const double wdis = room_width + margin*2;
    if (inst->x > room_width + margin)
    {
      inst->x -= wdis*ceil((inst->x - (room_width + margin))/wdis);
    }
    else if (inst->x < -margin)
    {
      inst->x += wdis*ceil(((-margin) - inst->x)/wdis);
    }
  }
  if (vert)
  {
    const double hdis = room_height + margin*2;
    if (inst->y > room_height + margin)
    {
      inst->y -= hdis*ceil((inst->y - (room_height + margin))/hdis);
    }
    else if (inst->y < -margin)
    {
      inst->y += hdis*ceil(((-margin) - inst->y)/hdis);
    }This means that when the margin is set to a high negative value, ie more than half the room_width or something and both if statements are true it doesn't actually wrap and just moves the instance continuously left/up. By leaving the else out it wraps correctly mirrored which is a better way to handle things.

[RetroX]

Also @Retro, I once sent Josh all the functions I had done. He probably forgot about them.

Josh != everyone else

Post made March 09, 2011, 09:14:31 am was deleted at the author's request.

[RetroX]

Also @Retro, I once sent Josh all the functions I had done. He probably forgot about them.

Josh != everyone else

Sincerely,
RetroX and everyone else.

Yes, thank you for enforcing my point.  Please post them if you want them to be reviewed by everyone else.

Post made March 10, 2011, 11:40:42 am was deleted at the author's request.

[RetroX]

Also @Retro, I once sent Josh all the functions I had done. He probably forgot about them.

Josh != everyone else

Sincerely,
RetroX and everyone else.

Yes, thank you for enforcing my point.  Please post them if you want them to be reviewed by everyone else.

I didn't reinforce your point, silly. Your own post was against the point that you made. By saying "sincerely RetroX and everyone else," you say that no one but me knows of them. That is not true.

Either way, polygone seems more interested than I am in coding these functions.

Yes, and only you and Josh know.

Josh != everyone else

Post made March 11, 2011, 05:18:24 am was deleted at the author's request.

[Josh @ Dreamland]

...
His point is, if you have functions, post them here. I'm not going to do anything with them, and no one else gives a shit about your functions unless they're posted here. So post them, or drop them.