Josh @ Dreamland
|
|
Posted on: June 02, 2013, 03:19:30 pm |
|
|
Prince of all Goldfish
Location: Pittsburgh, PA, USA Joined: Feb 2008
Posts: 2950
|
Dear Polyfuck: Stop breaking the fucking repo
If you continue to break the fucking repo on all non-Windows platforms--which I'll remind you that the majority of our users are on, because the rest can tolerate GM by virtue of being able to tolerate Winblows--I'm going to have you join Robert in club commit-to-fork-and-drop-pull-requests, where you should have been from the get-go.
We have *far* too many problems with the engine from the new MinGW release and the new release zip to be worrying about you fucking breaking mouse_x on a whim without so much as telling anyone.
At very least, tell Robert, because he won't fucking shut up about it until it's fixed, whether he fixes it, or he asks me how to fix it, or I fix it.
|
|
« Last Edit: June 02, 2013, 03:23:15 pm by Josh @ Dreamland »
|
Logged
|
"That is the single most cryptic piece of code I have ever seen." -Master PobbleWobble "I disapprove of what you say, but I will defend to the death your right to say it." -Evelyn Beatrice Hall, Friends of Voltaire
|
|
|
Goombert
|
|
Reply #1 Posted on: June 02, 2013, 03:27:52 pm |
|
|
Location: Cappuccino, CA Joined: Jan 2013
Posts: 2993
|
In his defense he did tell us, I am the only one who pays attention half the time otherwise I wouldn't have suggested it was him who broke it only for you guys to discover it was him who broke it.
Edit: Hey I am not the one who won't shut up about it, other people bitching its broke, I only mentioned its not broke for me too. And second of all, your rant really isn't an announcement, you give me a guff about posting stuff here I shouldn't be, both you and poly, when you post tons of crap here that shouldn't be.
|
|
« Last Edit: June 02, 2013, 03:31:33 pm by Robert B Colton »
|
Logged
|
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.
|
|
|
polygone
|
|
Reply #2 Posted on: June 02, 2013, 03:56:37 pm |
|
|
Location: England Joined: Mar 2009
Posts: 794
|
I did tell Robert, I also put a note in the commit message; I should have made an issue report for it as well though. The problem is I can't run and test on other platforms so I can't add in that code when something is changed like that. So I don't really have any other option but to commit it as it is, it's hardly going to cause that much an issue; I certainly consider it preferably to simply stifling progress.
|
|
« Last Edit: June 02, 2013, 03:58:43 pm by polygone »
|
Logged
|
I honestly don't know wtf I'm talking about but hopefully I can muddle my way through.
|
|
|
Josh @ Dreamland
|
|
Reply #3 Posted on: June 02, 2013, 04:18:20 pm |
|
|
Prince of all Goldfish
Location: Pittsburgh, PA, USA Joined: Feb 2008
Posts: 2950
|
Git has branches for a reason. They are trivial to use and create. Most projects have branches that live less than a week on average. When you want to make a change that breaks fucking everything (such as moving updaters someplace platform-specific, or moving wgl code to a new Bridges/ folder), you do so in a branch. Anyone that needs to work on that branch does so, and then it is merged into master.
Robert fucking refuses to use branches. You just didn't bother. Next time, do so.
|
|
|
Logged
|
"That is the single most cryptic piece of code I have ever seen." -Master PobbleWobble "I disapprove of what you say, but I will defend to the death your right to say it." -Evelyn Beatrice Hall, Friends of Voltaire
|
|
|
Goombert
|
|
Reply #4 Posted on: June 03, 2013, 02:47:16 am |
|
|
Location: Cappuccino, CA Joined: Jan 2013
Posts: 2993
|
I refuse to use branches because I don't break shit, I bridged all the Windowing and Graphics systems without any problems on any platforms. And I don't refuse to use branches I refuse to be patient with merging my branches, I like using the branch because it ensures people don't come along and fuck up what I am working on, and I like to commit several times while working to do things in steps and don't like to merge till I am ready.
|
|
|
Logged
|
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.
|
|
|
Josh @ Dreamland
|
|
Reply #5 Posted on: June 03, 2013, 10:34:24 am |
|
|
Prince of all Goldfish
Location: Pittsburgh, PA, USA Joined: Feb 2008
Posts: 2950
|
Using your fork and using a branch are two different things. If you don't use a branch, no one will accept any pull requests until any breaking changes you are working on which should have been in a branch are completed. This includes changes which just aren't given the benefit of the doubt, even if you think they work.
The switch to Bridges/ was trivial enough for me not to give you a hassle. Don't think for a second that every change you may make at my suggestion will be so nonchalantly merged.
|
|
|
Logged
|
"That is the single most cryptic piece of code I have ever seen." -Master PobbleWobble "I disapprove of what you say, but I will defend to the death your right to say it." -Evelyn Beatrice Hall, Friends of Voltaire
|
|
|
Goombert
|
|
Reply #6 Posted on: June 03, 2013, 01:53:00 pm |
|
|
Location: Cappuccino, CA Joined: Jan 2013
Posts: 2993
|
Josh, you bitch at me %99 of the time its me fixing shit while they break it lol ^_^
|
|
|
Logged
|
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.
|
|
|
forthevin
|
|
Reply #7 Posted on: June 03, 2013, 04:09:22 pm |
|
|
Joined: Jun 2012
Posts: 167
|
I personally try to be careful with changes. I do have commit access, but I still use my fork now and then if I am uncertain about changes, the changes could be critical, and/or I cannot test them properly at the given time.
That said, I think this is mainly an issue of different expectations in regards to the master branch of the enigma-dev/enigma-dev repository. Given the events discussed here and the discussion itself, and that the master branch is rather important, I think it would make sense to set up some guidelines for doing changes to the repository, which contributors, old as new, can use to figure out how to do changes to the main branch. I am going to write out a proposal for these guidelines in a new thread so that we can discuss them there.
|
|
|
Logged
|
|
|
|
Goombert
|
|
Reply #8 Posted on: June 03, 2013, 05:23:07 pm |
|
|
Location: Cappuccino, CA Joined: Jan 2013
Posts: 2993
|
Excellente forthevin, and I'd just like to state you are our best contributor ^_^ well in my personal opinion.
|
|
|
Logged
|
I think it was Leonardo da Vinci who once said something along the lines of "If you build the robots, they will make games." or something to that effect.
|
|
|
forthevin
|
|
Reply #9 Posted on: June 04, 2013, 12:01:49 pm |
|
|
Joined: Jun 2012
Posts: 167
|
Well, I don't know if I really deserve such high praise, but I do admit that I try to be a good contributor .
|
|
|
Logged
|
|
|
|
polygone
|
|
Reply #10 Posted on: June 04, 2013, 12:29:22 pm |
|
|
Location: England Joined: Mar 2009
Posts: 794
|
Forthevin is best at large functional changes/implementation and resolving those annoying little bugs that inevitably wind up occurring and are tricky to squash. I think we need him to have a look over the issues page again, those reports are stacking up Robert is best at implementing new systems and expanding available features. I am best at finding those annoying bugs that always crop up everywhere, odd jobs and knowing wtf is going on with everything ENIGMA related. ExDeus is best at odd graphical systems. Cheeseboy is best at config set-up, knowing about sound shit and annoying people into doing things. Josh is best at taking 2 years to write a parser. Darkace is best at being generally useless. Ism and TGMG died in a car crash and were later found out to be having an affair.
|
|
« Last Edit: June 04, 2013, 12:34:10 pm by polygone »
|
Logged
|
I honestly don't know wtf I'm talking about but hopefully I can muddle my way through.
|
|
|
|
DarkAceZ
|
|
Reply #12 Posted on: June 22, 2013, 10:42:45 pm |
|
|
Location: United States Joined: Dec 2011
Posts: 75
|
Darkace is best at being generally useless.
But I still do more than you. :<
|
|
|
Logged
|
My Goodness! Is it 4:30? I'm supposed to be having a back, sack and crack! [edit]
|
|
|
|